Uh oh!
There was an error while loading. Please reload this page.
fix(core): restore app menu label, show "Settings" for sub-sections - #60897
Merged
Conversation
pringelmann
requested review from
nfebe, sorbaugh and susnux
and removed request for
a teamJune 1, 2026 10:47
kra-mo
approved these changes
Jun 1, 2026
kra-mo
left a comment
Member
There was a problem hiding this comment.
Looks good, but would it not be possible to also just show the same generic icon for settings instead of the a11y/personal icons?
pringelmann
commented
Jun 1, 2026
ContributorAuthor
Ah yes, good catch. Changed to always use settings icon instead of subsection icon |
jancborchardt
approved these changes
Jun 1, 2026
jancborchardt
left a comment
Member
There was a problem hiding this comment.
Looks great! :) Would have also noted the icon but is already fixed, great stuff 👍
pringelmannforce-pushed
the
fix/current-app-label-followups
branch
4 times, most recently
from
June 2, 2026 09:26
6950129 to
cfaafbdCompare…gger Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmannforce-pushed
the
fix/current-app-label-followups
branch
from
June 2, 2026 09:51
cfaafbd to
6887a37Comparepringelmann
commented
Jun 2, 2026
ContributorAuthor
/compile amend |
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
fix/current-app-label-followups
branch
from
June 2, 2026 11:47
6887a37 to
76818dbComparepringelmann
commented
Jun 2, 2026
ContributorAuthor
/backport to stable34 |
pringelmann
commented
Jun 2, 2026
ContributorAuthor
@sorbaugh can I take you up on that force merge please? :) |
Uh oh!
There was an error while loading. Please reload this page.
3 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two follow-ups from #60757.
Settings sub-section names ("Personal info", "Appearance and accessibility", ...) were too long to fit next to the centered search, which is why we hid the label below 1400px. Show "Settings" for any
type === 'settings'entry instead, and restore the always-visible label at >= 1024px with the original width cap.Preview url: https://nc-preview.tail22c02b.ts.net/
The icon-centering issue (item 1 in the issue) falls out of this: the text slot is never empty while the button is visible, so the icon sits where it should.
Checklist
stable32)