Skip to content

fix(ViewOnlyPlugin): Allow COPY and MOVE operations within the same storage - #61497

Merged
AndyScherzinger merged 2 commits into
masterfrom
fix/viewonlyplugin/allow-copy-move-same-storage
Jul 15, 2026
Merged

fix(ViewOnlyPlugin): Allow COPY and MOVE operations within the same storage#61497
AndyScherzinger merged 2 commits into
masterfrom
fix/viewonlyplugin/allow-copy-move-same-storage

Conversation

@provokateurin

Copy link
Copy Markdown
Member

The checks are only supposed to block copying and moving files out of the share, as that would allow to circumvent the "allow download and sync" restriction. However they applied to all operations regardless of the destination and therefore blocked legitimate copying and moving within the same share.

@provokateurinprovokateurin added this to the Nextcloud 35 milestone Jun 22, 2026
@provokateurin
provokateurin requested a review from a team as a code ownerJune 22, 2026 13:25
@provokateurinprovokateurin added bug 3. to review Waiting for reviews labels Jun 22, 2026
@provokateurin
provokateurin requested review from Altahrim, ArtificialOwl and come-nc and removed request for a teamJune 22, 2026 13:25
@provokateurinprovokateurin changed the title Fix/viewonlyplugin/allow copy move same storagefix(ViewOnlyPlugin): Allow COPY and MOVE operations within the same storageJun 22, 2026
@provokateurin

Copy link
Copy Markdown
MemberAuthor

/backport to stable34

@provokateurin

Copy link
Copy Markdown
MemberAuthor

/backport to stable33

@provokateurin

Copy link
Copy Markdown
MemberAuthor

/backport to stable32

@provokateurin
provokateurin marked this pull request as draft June 22, 2026 13:46
@provokateurinprovokateurin added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jun 22, 2026
Signed-off-by: provokateurin <kate@provokateurin.de>
…torage
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin
provokateurin marked this pull request as ready for review July 15, 2026 06:02
@provokateurin
provokateurinforce-pushed the fix/viewonlyplugin/allow-copy-move-same-storage branch from b8f1f7f to 865ee69CompareJuly 15, 2026 06:02
@provokateurinprovokateurin added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 15, 2026
@AndyScherzinger
AndyScherzinger merged commit 150e157 into masterJul 15, 2026
213 of 222 checks passed
@AndyScherzinger
AndyScherzinger deleted the fix/viewonlyplugin/allow-copy-move-same-storage branch July 15, 2026 09:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@provokateurin@AndyScherzinger@susnux