Uh oh!
There was an error while loading. Please reload this page.
fix(core): resolve some edge cases with recommended apps - #61663
Conversation
pringelmann
commented
Jun 30, 2026
Could be folded in here since you already touch this flow. Happy to pick it up if you're busy, just let me know. |
pringelmann
commented
Jun 30, 2026
@susnux The per-app enable loop here reintroduces multiple password prompts. #60068 switched install to a single bulk enable specifically so strict confirmation only prompts once. Installing N recommended apps now pops N password dialogs. That's also why the setup.ts Cypress spec is red: it expects one bulk enable + one dialog. How do you want to handle it? |
susnux
commented
Jun 30, 2026
Sounds like we should bring that back, but that needs backend changes now. But the cypress test I can adjust here for now. |
joshtrichards
commented
Jun 30, 2026
Related bug: #32310 |
There are some edge cases to keep in mind: 1. Not always install the code server if office is not installed 2. Handle installed apps properly 3. Properly handle aborted password confirmation Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
5e0827c to
d176b42Comparesusnux
commented
Jul 3, 2026
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
susnux
commented
Jul 3, 2026
/backport to stable34 |
Summary
There are some edge cases to keep in mind:
Checklist
3. to review, feature component)stable32)AI (if applicable)