Uh oh!
There was an error while loading. Please reload this page.
[stable33] fix(files_sharing): validate input in PublicPreviewController#getPreview - #61959
Closed
backportbot[bot] wants to merge 8 commits into
Closed
[stable33] fix(files_sharing): validate input in PublicPreviewController#getPreview#61959backportbot[bot] wants to merge 8 commits into
backportbot[bot] wants to merge 8 commits into
Conversation
Return 400 Bad Request when the file parameter is empty and the shared node is a folder, instead of passing the folder itself to getPreview which triggers an internal server error. Also rename the local variable to $fileNode to prevent the catch block from calling getMimeType() on the original string parameter when get() throws NotFoundException. Fixes#59229 Signed-off-by: Matt Van Horn <mvanhorn@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Signed-off-by: Josh <josh.t.richards@gmail.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
…variable naming And slightly streamline the logic for clarity. Signed-off-by: Josh <josh.t.richards@gmail.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
…ler#getPreview edge cases Signed-off-by: Josh <josh.t.richards@gmail.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
… in tests Signed-off-by: Josh <josh.t.richards@gmail.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
…lean Signed-off-by: Josh <josh.t.richards@gmail.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
…bles Addresses review feedback on PR #59253: * Catch `NotPermittedException` from `$shareNode->get()` and return 403 FORBIDDEN instead of propagating an internal server error (per @kesselb on line 133). * Drop the unused `$e` capture from the existing `NotFoundException` and `\InvalidArgumentException` catch blocks, using PHP 8.0 no-capture syntax (per @kesselb on line 150). * Add `testPreviewFolderSubfolderReturnsBadRequest` covering the branch where a folder share resolves `$file` to a subfolder and must return 400 (per @Copilot on line 136). Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
fix(files_sharing): return 403 on NotPermittedException and sync openapi [skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #59253
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.