Skip to content

fix: Output shape validation will delete keys when there is a list of files - #61962

Merged
lukasdotcom merged 1 commit into
masterfrom
fix-output-validation
Jul 15, 2026
Merged

fix: Output shape validation will delete keys when there is a list of files#61962
lukasdotcom merged 1 commit into
masterfrom
fix-output-validation

Conversation

@lukasdotcom

@lukasdotcomlukasdotcom commented Jul 9, 2026

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

If you have an output that has a ListOfFiles it will delete the other outputs before that one causing them to go missing.

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@lukasdotcom
lukasdotcom requested a review from a team as a code ownerJuly 9, 2026 21:29
@lukasdotcomlukasdotcom added bug 3. to review Waiting for reviews labels Jul 9, 2026
@lukasdotcom
lukasdotcom requested review from come-nc, leftybournes, provokateurin and salmart-dev and removed request for a teamJuly 9, 2026 21:29
@lukasdotcomlukasdotcom mentioned this pull request Jul 9, 2026
Merged
1 task
marcelklehr
marcelklehr reviewed Jul 10, 2026
View reviewed changes
Comment threadlib/private/TaskProcessing/Manager.php
@marcelklehr

marcelklehr commented Jul 10, 2026

Copy link
Copy Markdown
Member

Heh, found the same issue recently, while working on #61689

@lukasdotcom
fix: Output shape validation will delete keys when there is a list of…
9f719d0
… files
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
@lukasdotcom
lukasdotcomforce-pushed the fix-output-validation branch from be8f2d2 to 9f719d0CompareJuly 10, 2026 12:12
@lukasdotcom

lukasdotcom commented Jul 10, 2026

Copy link
Copy Markdown
MemberAuthor

Heh, found the same issue recently, while working on #61689

I found it when working on #61963 :)

julien-nc
julien-nc approved these changes Jul 15, 2026
View reviewed changes

@julien-ncjulien-nc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, looks good.

@lukasdotcom
lukasdotcom merged commit fbb559d into masterJul 15, 2026
211 of 220 checks passed
@lukasdotcom
lukasdotcom deleted the fix-output-validation branch July 15, 2026 20:04
@marcelklehr

marcelklehr commented Jul 16, 2026

Copy link
Copy Markdown
Member

Might be nice to backport this, no?

@lukasdotcom

lukasdotcom commented Jul 16, 2026

Copy link
Copy Markdown
MemberAuthor

/backport to stable34

@lukasdotcom

lukasdotcom commented Jul 16, 2026

Copy link
Copy Markdown
MemberAuthor

/backport to stable33

@backportbotbackportbotBot mentioned this pull request Jul 16, 2026
Merged
@lukasdotcom

lukasdotcom commented Jul 16, 2026

Copy link
Copy Markdown
MemberAuthor

/backport to stable32

This was referenced Jul 16, 2026
Merged
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Aug 11, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelklehrmarcelklehrmarcelklehr approved these changes
@julien-ncjulien-ncjulien-nc approved these changes
@salmart-devsalmart-devAwaiting requested review from salmart-devsalmart-dev is a code owner automatically assigned from nextcloud/server-backend
@leftybournesleftybournesAwaiting requested review from leftybournesleftybournes is a code owner automatically assigned from nextcloud/server-backend
@provokateurinprovokateurinAwaiting requested review from provokateurinprovokateurin is a code owner automatically assigned from nextcloud/server-backend
@come-nccome-ncAwaiting requested review from come-nccome-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lukasdotcom@marcelklehr@julien-nc