Uh oh!
There was an error while loading. Please reload this page.
fix(UserPlugin): Don't return mail matches on user id search - #61981
Merged
Conversation
DerDreschner
requested review from
ArtificialOwl, leftybournes and provokateurin
and removed request for
a teamJuly 10, 2026 21:10
8 tasks
DerDreschner
commented
Jul 10, 2026
ContributorAuthor
/backport to stable32 |
DerDreschner
commented
Jul 10, 2026
ContributorAuthor
/backport to stable33 |
DerDreschner
commented
Jul 10, 2026
ContributorAuthor
/backport to stable34 |
DerDreschnerforce-pushed
the
fix/respect-full-match-mail-in-edge-cases
branch
from
July 10, 2026 21:13
ab377f6 to
70e10a5CompareDerDreschner
enabled auto-merge
July 10, 2026 21:14
DerDreschnerforce-pushed
the
fix/respect-full-match-mail-in-edge-cases
branch
from
July 12, 2026 00:59
70e10a5 to
4b50b87CompareSebastianKrupinski
approved these changes
Jul 13, 2026
ChristophWurst
approved these changes
Jul 13, 2026
DerDreschnerforce-pushed
the
fix/respect-full-match-mail-in-edge-cases
branch
from
July 14, 2026 07:20
4b50b87 to
15ae364CompareAssisted-by: ClaudeCode:claude-fable-5 Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
DerDreschnerforce-pushed
the
fix/respect-full-match-mail-in-edge-cases
branch
from
July 14, 2026 12:50
15ae364 to
aa6a596CompareChristophWurst
disabled auto-merge
July 14, 2026 15:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #47686 , the backend search not only returns matches by user ID, but also by their mail address. This is very confusing, as you would expect that to be impossible when the
shareapi_restrict_user_enumeration_full_match_emailsetting is being set tono.This PR fixes that by checking if the matched user in the user ID code branch was actually a match by user ID and not by something else (like the mail address) as well as adding integration tests to prevent that from happening in the future.
Checklist
3. to review, feature component)stable32)AI (if applicable)