Skip to content

perf(workflow): Implement result cache for IP checks - #62039

Merged
nickvergessen merged 4 commits into
masterfrom
bugfix/noid/improve-performance-of-checks
Jul 13, 2026
Merged

perf(workflow): Implement result cache for IP checks#62039
nickvergessen merged 4 commits into
masterfrom
bugfix/noid/improve-performance-of-checks

Conversation

@nickvergessen

@nickvergessennickvergessen commented Jul 13, 2026

Copy link
Copy Markdown
Member

Summary

  • When the workflows are checked hundreds/thousands of times in the same request, the IP address as well as the time are not changing, so we can simply cache the result on a per operation+value level

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@nickvergessen
perf(workflow): Implement result cache for IP checks
21d7937
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
perf(workflows): Fix cache in request time check
75a6822
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
chore(workflow): Simplify code in URL check
c0f8fa8
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen added this to the Nextcloud 35 milestone Jul 13, 2026
@nickvergessennickvergessen self-assigned this Jul 13, 2026
@nickvergessen

nickvergessen commented Jul 13, 2026

Copy link
Copy Markdown
MemberAuthor

/backport to stable34

@nickvergessen

nickvergessen commented Jul 13, 2026

Copy link
Copy Markdown
MemberAuthor

/backport to stable33

@nickvergessen

nickvergessen commented Jul 13, 2026

Copy link
Copy Markdown
MemberAuthor

/backport to stable32

@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 13, 2026
come-nc
come-nc requested changes Jul 13, 2026
View reviewed changes
Comment threadapps/workflowengine/lib/Check/RequestRemoteAddress.php Outdated
@nickvergessen
chore(workflows): Migrate to CappedMemoryCache
e7004a5
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessen merged commit 5d6a26e into masterJul 13, 2026
189 of 196 checks passed
@nickvergessen
nickvergessen deleted the bugfix/noid/improve-performance-of-checks branch July 13, 2026 11:39
This was referenced Jul 13, 2026
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@CarlSchwanCarlSchwanCarlSchwan approved these changes
@provokateurinprovokateurinprovokateurin approved these changes
@SystemKeeperSystemKeeperAwaiting requested review from SystemKeeper
@blizzzblizzzAwaiting requested review from blizzzblizzz is a code owner
@come-nccome-ncAwaiting requested review from come-nc

Assignees

@nickvergessennickvergessen

Labels

4. to releaseReady to be released and/or waiting for tests to finishfeature: workflowsperformance 🚀

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen@ChristophWurst@CarlSchwan@provokateurin@come-nc