fix(files_sharing): Allow access to shares by disabled users if hide_disabled_user_shares is enabled

[provokateurin]

No description provided.

[provokateurin]

/backport to stable34 please

[provokateurin]

/backport to stable33 please

[provokateurin]

/backport to stable32 please

[provokateurin]

/backport to stable31 please

[provokateurin]

/backport to stable30 please

[grembo]

Without mentioning it in the commit message, this changed the default value of hide_disabled_user_shares from no to yes. After upgrading, internally shared folders of disabled users disappeared.

This could be rectified by running

./occ config:app:set files_sharing hide_disabled_user_shares --value no

Documentation at https://github.com/nextcloud/documentation/blob/master/admin_manual/configuration_user/user_configuration.rst#disable-and-enable-users needs to be adapted and this should be mentioned in release notes.

[grembo]

If I understand the change correctly, it actually removes the option of disabling access to external links/shares of disabled users while maintaining access to internal shares (which was the previous default). Now, in order to keep access to internally shared folders, external access is also granted. IMHO this is suboptimal. I think a better solution would be to introduce a new configuration setting hide_disabled_user_external_shares which defaults to yes and restore the previous meaning and default of hide_disabled_user_shares.