Skip to content

Allow getting the filepath when getting cached mounts by fileid - #6220

Merged
LukasReschke merged 1 commit into
masterfrom
cached-mount-info-filepath
Nov 8, 2017
Merged

Allow getting the filepath when getting cached mounts by fileid#6220
LukasReschke merged 1 commit into
masterfrom
cached-mount-info-filepath

Conversation

@icewind1991

Copy link
Copy Markdown
Member

This makes it cheap to not only get all users with access to a file but also get the path to the file for those users.

@icewind1991icewind1991 added the 3. to review Waiting for reviews label Aug 22, 2017
@icewind1991icewind1991 added this to the Nextcloud 13 milestone Aug 22, 2017
@icewind1991
icewind1991force-pushed the cached-mount-info-filepath branch from 4dbaef2 to 05e1004CompareAugust 22, 2017 15:44
@codecov

codecovBot commented Aug 22, 2017

Copy link
Copy Markdown

Codecov Report

Merging #6220 into master will increase coverage by <.01%.
The diff coverage is 94.73%.

@@ Coverage Diff @@## master #6220 +/- ##
============================================
+ Coverage 52.82% 52.83% +<.01% - Complexity 22802 22806 +4 
============================================
Files 1442 1443 +1 Lines 88562 88581 +19 Branches 1349 1349 ============================================
+ Hits 46787 46805 +18 - Misses 41775 41776 +1
Impacted FilesCoverage ΔComplexity Δ
lib/private/Files/Config/UserMountCache.php92.89% <100%> (+0.39%)40 <0> (ø)⬇️
lib/private/Files/Config/CachedMountFileInfo.php90% <90%> (ø)4 <4> (?)
lib/private/Server.php83.47% <0%> (-0.13%)124% <0%> (ø)
lib/private/Security/CertificateManager.php92.07% <0%> (+0.99%)39% <0%> (ø)⬇️

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

Signed-off-by: Robin Appelman <robin@icewind.nl>
@MorrisJobke
MorrisJobkeforce-pushed the cached-mount-info-filepath branch from 97d1ffe to 3f0cb13CompareOctober 27, 2017 12:36
@MorrisJobke

Copy link
Copy Markdown
Member

Rebased to trigger CI again.

@MorrisJobke

Copy link
Copy Markdown
Member

@rullzer@nickvergessen Please have a look at this.

@LukasReschke
LukasReschke merged commit 989a8a3 into masterNov 8, 2017
@LukasReschke
LukasReschke deleted the cached-mount-info-filepath branch November 8, 2017 23:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@MorrisJobke@LukasReschke