Skip to content

Remove old perl script to update l10n files - #6265

Merged
MorrisJobke merged 1 commit into
masterfrom
unperl-l10n
Feb 9, 2018
Merged

Remove old perl script to update l10n files#6265
MorrisJobke merged 1 commit into
masterfrom
unperl-l10n

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

Thanks @jakobsack

@mention-bot

Copy link
Copy Markdown

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @jakobsack and @jancborchardt to be potential reviewers.

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

@codecov

codecovBot commented Aug 25, 2017

Copy link
Copy Markdown

Codecov Report

Merging #6265 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #6265 +/- ##
============================================
- Coverage 51.69% 51.69% -0.01% 
Complexity 25382 25382 ============================================
Files 1599 1599 Lines 95090 95090 Branches 1376 1376 ============================================
- Hits 49161 49160 -1 - Misses 45929 45930 +1
Impacted FilesCoverage ΔComplexity Δ
lib/private/Files/Cache/Propagator.php94.93% <0%> (-1.27%)16% <0%> (ø)

@nickvergessen

Copy link
Copy Markdown
Member

Can we avoid the new folder in root?
And maybe reuse the l10n folder instead?

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

And maybe reuse the l10n folder instead?

The idea is to drop the l10n because in all other cases (all apps out there and also all folders in the server) this holds the actual l10n stuff - except in the root of the server, which is quite cumbersome.

Also the logic of the extraction code now uses this folder as indication of the root and therefore is a lot easier to understand, because this is the only way it works and it works for all apps and the server. I will do additional tests later on this.

@MorrisJobkeMorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 6, 2017
@nickvergessen

Copy link
Copy Markdown
Member

Okay then ping @LukasReschke to adjust the packaging script

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

Okay then ping @LukasReschke to adjust the packaging script

Once it is ready :)

@rullzer

Copy link
Copy Markdown
Member

CI not happy

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

CI not happy

I know - release script needs to be touched as well. Let me do a final test

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

@rullzer@nickvergessen This is now good to go in. Please review

@MorrisJobke
MorrisJobke merged commit 0841d29 into masterFeb 9, 2018
@MorrisJobke
MorrisJobke deleted the unperl-l10n branch February 9, 2018 08:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@MorrisJobke@mention-bot@nickvergessen@rullzer@ChristophWurst