Skip to content

allow apps to control the trash bin - #6503

Merged
schiessle merged 1 commit into
masterfrom
allow-apps-to-control-trash-bin
Sep 15, 2017
Merged

allow apps to control the trash bin#6503
schiessle merged 1 commit into
masterfrom
allow-apps-to-control-trash-bin

Conversation

@schiessle

Copy link
Copy Markdown
Member

Allow apps to disable the trash bin for certain files.

@blizzzblizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 15, 2017
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
@schiessle
schiessleforce-pushed the allow-apps-to-control-trash-bin branch from dc52c1c to 6e69881CompareSeptember 15, 2017 09:33
@codecov

codecovBot commented Sep 15, 2017

Copy link
Copy Markdown

Codecov Report

Merging #6503 into master will decrease coverage by 2.09%.
The diff coverage is 74.07%.

@@ Coverage Diff @@## master #6503 +/- ##
============================================
- Coverage 55.53% 53.43% -2.1% - Complexity 21244 22542 +1298 
============================================
Files 1253 1408 +155 Lines 73203 87206 +14003 Branches 0 1328 +1328 ============================================
+ Hits 40652 46602 +5950 - Misses 32551 40604 +8053
Impacted FilesCoverage ΔComplexity Δ
...pps/files_trashbin/lib/Events/MoveToTrashEvent.php55.55% <55.55%> (ø)4 <4> (?)
apps/files_trashbin/lib/Storage.php78.94% <83.33%> (+1.39%)35 <1> (+3)⬆️
apps/sharebymail/tests/SettingsTest.php52.17% <0%> (-47.83%)3% <0%> (ø)
lib/private/Security/RateLimiting/Limiter.php55.55% <0%> (-44.45%)5% <0%> (ø)
settings/Controller/EncryptionController.php56% <0%> (-37.34%)8% <0%> (ø)
settings/Controller/GroupsController.php64.61% <0%> (-35.39%)9% <0%> (ø)
...ps/comments/tests/Unit/AppInfo/ApplicationTest.php69.56% <0%> (-30.44%)4% <0%> (ø)
apps/user_ldap/lib/Configuration.php41.5% <0%> (-29.46%)86% <0%> (ø)
apps/encryption/lib/Command/EnableMasterKey.php75% <0%> (-25%)5% <0%> (ø)
lib/private/AvatarManager.php61.9% <0%> (-24.77%)4% <0%> (ø)
... and 333 more

@schiessle
schiessle merged commit 8500e11 into masterSep 15, 2017
@schiessle
schiessle deleted the allow-apps-to-control-trash-bin branch September 15, 2017 09:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementfeature: trashbin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@schiessle@icewind1991@blizzz