Skip to content

Create activities for (un)publishing calendar events - #6590

Merged
MorrisJobke merged 3 commits into
masterfrom
dav-create-activities-for-publishing
Dec 11, 2017
Merged

Create activities for (un)publishing calendar events#6590
MorrisJobke merged 3 commits into
masterfrom
dav-create-activities-for-publishing

Conversation

@tcitworld

@tcitworldtcitworld commented Sep 20, 2017

Copy link
Copy Markdown
Member

Creates corresponding activities whenever a calendar is (un)published.

@tcitworld

tcitworld commented Sep 20, 2017

Copy link
Copy Markdown
MemberAuthor

I wrote You published calendar {calendar} but maybe we could have the same as the files app : You shared Calendar {calendar} as public link.

@tcitworldtcitworld added this to the Nextcloud 13 milestone Sep 20, 2017
@nickvergessen

nickvergessen commented Sep 20, 2017

Copy link
Copy Markdown
Member

I would go for "shared as public link yeah

@tcitworld

tcitworld commented Sep 20, 2017

Copy link
Copy Markdown
MemberAuthor

In that case, there's a lot of wording to change in the calendar app too.

@georgehrke

georgehrke commented Sep 24, 2017

Copy link
Copy Markdown
Member

I think we should go for You shared Calendar {calendar} as public link, because that's how it's called in the files app. We should rename the wording in the calendar app too I guess.

@georgehrke

georgehrke commented Nov 12, 2017

Copy link
Copy Markdown
Member

@tcitworld Can you please change the wording accordingly? :)

@georgehrke

georgehrke commented Nov 12, 2017

Copy link
Copy Markdown
Member

Failing test looks unrelated

@MorrisJobkeMorrisJobke mentioned this pull request Dec 8, 2017
Merged
28 tasks
@MorrisJobke

MorrisJobke commented Dec 11, 2017

Copy link
Copy Markdown
Member

Let me update the wording.

@codecov

codecovBot commented Dec 11, 2017•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #6590 into master will decrease coverage by 23.02%.
The diff coverage is 10.52%.

@@ Coverage Diff @@## master #6590 +/- ##
=============================================
- Coverage 51.07% 28.04% -23.03% + Complexity 24830 23526 -1304 
=============================================
Files 1594 1437 -157 Lines 94485 78699 -15786 Branches 1365 0 -1365 =============================================
- Hits 48256 22072 -26184 - Misses 46229 56627 +10398
Impacted FilesCoverage ΔComplexity Δ
apps/dav/lib/CalDAV/Activity/Provider/Calendar.php0% <0%> (ø)65 <0> (+4)⬆️
apps/dav/lib/AppInfo/Application.php0% <0%> (-20.23%)14 <0> (ø)
apps/dav/lib/CalDAV/CalDavBackend.php0% <0%> (-84.22%)244 <0> (ø)
apps/dav/lib/CalDAV/Activity/Backend.php26.02% <100%> (+4.02%)67 <2> (+2)⬆️
lib/private/Files/Mount/CacheMountProvider.php0% <0%> (-100%)4% <0%> (ø)
apps/admin_audit/composer/autoload.php0% <0%> (-100%)0% <0%> (ø)
apps/dav/lib/CalDAV/PublicCalendarRoot.php0% <0%> (-100%)4% <0%> (ø)
apps/dav/lib/Connector/Sabre/Server.php0% <0%> (-100%)1% <0%> (ø)
apps/files_versions/lib/Command/Expire.php0% <0%> (-100%)3% <0%> (ø)
apps/user_ldap/lib/Migration/UUIDFixGroup.php0% <0%> (-100%)1% <0%> (ø)
... and 832 more

MorrisJobke
MorrisJobke approved these changes Dec 11, 2017
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

rullzer
rullzer approved these changes Dec 11, 2017
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@rullzerrullzer added 4. to release Ready to be released and/or waiting for tests to finish 2. developing Work in progress and removed 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish labels Dec 11, 2017
@rullzer

rullzer commented Dec 11, 2017

Copy link
Copy Markdown
Member

Failing tests

tcitworldand others added 2 commits December 11, 2017 16:28
@tcitworld@rullzer
Create activities for (un)publishing calendar events
4c32de2
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@MorrisJobke@rullzer
Update wording
c76c7a9
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@rullzer
rullzerforce-pushed the dav-create-activities-for-publishing branch from d8643cf to c76c7a9CompareDecember 11, 2017 15:28
@rullzer
Fix tests
effde61
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer

rullzer commented Dec 11, 2017

Copy link
Copy Markdown
Member

Should be OK now but lets wait for CI to be nice and green

@tcitworld

tcitworld commented Dec 11, 2017

Copy link
Copy Markdown
MemberAuthor

Thx, missed bdb0265

@MorrisJobke

MorrisJobke commented Dec 11, 2017

Copy link
Copy Markdown
Member

Tests pass -> merging.

@MorrisJobke
MorrisJobke merged commit ba3c608 into masterDec 11, 2017
@MorrisJobke
MorrisJobke deleted the dav-create-activities-for-publishing branch December 11, 2017 16:13
@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Dec 11, 2017
@tcitworldtcitworld mentioned this pull request Jun 26, 2018
Closed
@nickvergessennickvergessen mentioned this pull request Jul 2, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@georgehrkegeorgehrkeAwaiting requested review from georgehrke
@schiessleschiessleAwaiting requested review from schiessle

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishfeature: activity and notificationfeature: dav

Projects

None yet

Milestone

Nextcloud 13

Development

Successfully merging this pull request may close these issues.

5 participants

@tcitworld@nickvergessen@georgehrke@MorrisJobke@rullzer