Uh oh!
There was an error while loading. Please reload this page.
Fix app nav img margin - #6623
Merged
Merged
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
juliusknorr
commented
Sep 23, 2017
Member
@skjnldsv Also happens to be an issue without an image, see the app management: |
MemberAuthor
@juliushaertl This is @jancborchardt's will. He wants users to be 'forced' to have some icons! :) |
juliusknorr
commented
Sep 23, 2017
Member
Ah ok, is there already an issue for the parts missing an icon in the server repo? |
skjnldsv
commented
Sep 23, 2017
MemberAuthor
You mean in the apps management section? |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Codecov Report
@@ Coverage Diff @@## master #6623 +/- ##
============================================
- Coverage 53.06% 53.06% -0.01%
Complexity 22553 22553 ============================================
Files 1414 1414 Lines 87745 87745 Branches 1340 1340 ============================================
- Hits 46565 46564 -1 - Misses 41180 41181 +1
|
skjnldsv
commented
Sep 23, 2017
MemberAuthor
@nextcloud/designers please review :) |
juliusknorr
approved these changes
Sep 23, 2017
juliusknorr
commented
Sep 23, 2017
Member
rullzer
approved these changes
Sep 24, 2017
jancborchardt
commented
Sep 25, 2017
Member
@skjnldsv see, it pushes us to add icons ;) |
skjnldsv
commented
Sep 25, 2017
MemberAuthor
@jancborchardt well done fine sir! You tricked me well! 😱😱 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix#6622
@nextcloud/designers