Skip to content

Fix app nav img margin - #6623

Merged
rullzer merged 3 commits into
masterfrom
fix-app-nav-img
Sep 24, 2017
Merged

Fix app nav img margin#6623
rullzer merged 3 commits into
masterfrom
fix-app-nav-img

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Sep 23, 2017

Copy link
Copy Markdown
Member

Fix#6622
@nextcloud/designers

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added 3. to review Waiting for reviews bug design Design, UI, UX, etc. regression labels Sep 23, 2017
@skjnldsvskjnldsv self-assigned this Sep 23, 2017
@juliusknorr

Copy link
Copy Markdown
Member

@skjnldsv Also happens to be an issue without an image, see the app management:

bildschirmfoto vom 2017-09-23 14-30-02

@skjnldsv

skjnldsv commented Sep 23, 2017

Copy link
Copy Markdown
MemberAuthor

@juliushaertl This is @jancborchardt's will. He wants users to be 'forced' to have some icons! :)
#6399 (comment)

@juliusknorr

Copy link
Copy Markdown
Member

Ah ok, is there already an issue for the parts missing an icon in the server repo?

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

You mean in the apps management section?

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@codecov

codecovBot commented Sep 23, 2017

Copy link
Copy Markdown

Codecov Report

Merging #6623 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #6623 +/- ##
============================================
- Coverage 53.06% 53.06% -0.01% 
Complexity 22553 22553 ============================================
Files 1414 1414 Lines 87745 87745 Branches 1340 1340 ============================================
- Hits 46565 46564 -1 - Misses 41180 41181 +1
Impacted FilesCoverage ΔComplexity Δ
apps/files_trashbin/lib/Trashbin.php72.28% <0%> (-0.25%)136% <0%> (ø)

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

@nextcloud/designers please review :)

@juliusknorr

Copy link
Copy Markdown
Member

@skjnldsv Yes. Found it #3987

@rullzer
rullzer merged commit 24a881f into masterSep 24, 2017
@rullzer
rullzer deleted the fix-app-nav-img branch September 24, 2017 11:07
@jancborchardt

Copy link
Copy Markdown
Member

@skjnldsv see, it pushes us to add icons ;)

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

@jancborchardt well done fine sir! You tricked me well! 😱😱

@MorrisJobkeMorrisJobke added this to the Nextcloud 13 milestone Oct 23, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv@juliusknorr@jancborchardt@rullzer@MorrisJobke