Skip to content

Fallback to filename based detection if the remote dav server doesn't… - #6682

Merged
rullzer merged 1 commit into
masterfrom
dav-mimetype-fallback
Dec 11, 2017
Merged

Fallback to filename based detection if the remote dav server doesn't…#6682
rullzer merged 1 commit into
masterfrom
dav-mimetype-fallback

Conversation

@icewind1991

Copy link
Copy Markdown
Member

… know the mimetype

Fixesicewind1991/files_markdown#65

… know the mimetype
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Sep 28, 2017
@icewind1991icewind1991 added this to the Nextcloud 13 milestone Sep 28, 2017
@codecov

codecovBot commented Sep 28, 2017

Copy link
Copy Markdown

Codecov Report

Merging #6682 into master will increase coverage by <.01%.
The diff coverage is 71.42%.

@@ Coverage Diff @@## master #6682 +/- ##
============================================
+ Coverage 53.03% 53.04% +<.01% - Complexity 22583 22585 +2 
============================================
Files 1417 1417 Lines 87866 87871 +5 Branches 1341 1341 ============================================
+ Hits 46600 46607 +7 + Misses 41266 41264 -2
Impacted FilesCoverage ΔComplexity Δ
lib/private/Files/Storage/DAV.php65.4% <71.42%> (+0.58%)163 <8> (+2)⬆️
apps/files_trashbin/lib/Trashbin.php72.53% <0%> (+0.24%)136% <0%> (ø)⬇️

@MorrisJobke

Copy link
Copy Markdown
Member

I cannot reproduce. I tested this with two servers and a remote share between them:

  • server 1 a has configured, that .md files should get mime type application/octet-stream
  • server 2 received the share and still had shown the octet-stream mime type

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobkeMorrisJobke mentioned this pull request Dec 8, 2017
28 tasks
@rullzer
rullzer merged commit e47137c into masterDec 11, 2017
@rullzer
rullzer deleted the dav-mimetype-fallback branch December 11, 2017 14:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@MorrisJobke@rullzer