Uh oh!
There was an error while loading. Please reload this page.
Allow ocs/v2.php/cloud/... routes - #691
Merged
Merged
Conversation
mention-bot
commented
Aug 1, 2016
@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @BernhardPosselt and @icewind1991 to be potential reviewers |
rullzer
commented
Aug 2, 2016
MemberAuthor
Depends on #445 so we actually know better if we broke anything. |
MorrisJobke
commented
Aug 2, 2016
Member
Tested and it works 👍 |
One of the possibilities of the old OCS API is that you can define the url yourself. This PR makes this possible again by adding an optional root elemenet to the route. Routes are thus: .../ocs/v2.php/<root>/<url> By default <root> = apps/<app> This will allow for example the provisioning API etc to be in ../ovs/v2/php/cloud/users
rullzerforce-pushed
the
ocs_allow_all_old_routes
branch
from
August 8, 2016 13:01
034f382 to
63f6d2dComparerullzer
commented
Aug 8, 2016
MemberAuthor
Ok so this works! |
rullzer
commented
Aug 9, 2016
MemberAuthor
For seeing it in action #777 |
LukasReschke
commented
Aug 9, 2016
Member
LGTM |
GitHubUser4234 pushed a commit
to GitHubUser4234/server
that referenced
this pull request
Aug 30, 2016
Allow ocs/v2.php/cloud/... routes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the possibilities of the old OCS API is that you can define the
url yourself.
This PR makes this possible again by adding an optional root elemenet to
the route. Routes are thus:
.../ocs/v2.php/<root>/<url>By default
<root>=apps/<app>This will allow for example the provisioning API etc to be in
../ovs/v2.php/cloud/users