Skip to content

Added additional methods for removal of sensitive info - #6977

Merged
nickvergessen merged 1 commit into
nextcloud:masterfrom
Fiech:master
Oct 27, 2017
Merged

Added additional methods for removal of sensitive info#6977
nickvergessen merged 1 commit into
nextcloud:masterfrom
Fiech:master

Conversation

@Fiech

@FiechFiech commented Oct 26, 2017

Copy link
Copy Markdown
Contributor

As per #6576

I'm unable to recreate the issue with the current server code, but the changes do not break the installation.

Edit by @MorrisJobke:closes#6576

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@MorrisJobke

Copy link
Copy Markdown
Member

@Fiech Could I ask you to add the sign-off message to this commit (then our CI also succeeds): See https://github.com/nextcloud/server/blob/master/CONTRIBUTING.md#sign-your-work for the why.

This should be possible by doing this:

git commit --amend -s
git push -f origin master

Thanks for your contribution

@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Oct 27, 2017
@MorrisJobkeMorrisJobke added this to the Nextcloud 13 milestone Oct 27, 2017
Signed-off-by: Johannes Schlichenmaier <johannes@schlichenmaier.info>
@codecov

codecovBot commented Oct 27, 2017

Copy link
Copy Markdown

Codecov Report

Merging #6977 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #6977 +/- ##
=========================================
Coverage 52.82% 52.82% Complexity 22802 22802 =========================================
Files 1442 1442 Lines 88562 88562 Branches 1349 1349 =========================================
Hits 46782 46782 Misses 41780 41780
Impacted FilesCoverage ΔComplexity Δ
lib/private/Log.php79.31% <ø> (ø)38 <0> (ø)⬇️
lib/private/Security/CertificateManager.php91.08% <0%> (-1%)39% <0%> (ø)
lib/private/Server.php83.59% <0%> (+0.12%)124% <0%> (ø)⬇️

@Fiech

Copy link
Copy Markdown
ContributorAuthor

Hey, just signed off my commit. Awesome, that everything is triggered automatically!

@nickvergessen
nickvergessen merged commit 7a4c0c6 into nextcloud:masterOct 27, 2017
nickvergessen added a commit that referenced this pull request Oct 27, 2017
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen mentioned this pull request Oct 27, 2017
@nickvergessen

Copy link
Copy Markdown
Member

Added some unit tests in #6981

Thanks!

rullzer added a commit that referenced this pull request Oct 30, 2017
nickvergessen added a commit that referenced this pull request Jan 3, 2018
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen added a commit that referenced this pull request Jan 3, 2018
Signed-off-by: Joas Schilling <coding@schilljs.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using encryption logs user password in clear-text

3 participants

@Fiech@MorrisJobke@nickvergessen