Uh oh!
There was an error while loading. Please reload this page.
Show favourite action as the first one in the file actions menu - #7012
Merged
Conversation
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
MorrisJobke
approved these changes
Oct 30, 2017
Codecov Report
@@ Coverage Diff @@## master #7012 +/- ##
============================================
+ Coverage 52.82% 52.83% +<.01%
Complexity 22802 22802 ============================================
Files 1442 1442 Lines 88563 88563 Branches 1349 1349 ============================================
+ Hits 46787 46788 +1 + Misses 41776 41775 -1
|
jancborchardt
commented
Oct 30, 2017
Member
Aaaah the order attribute! I was looking around a bit, didn’t find that. :D Thank you! Is it also possible that we reverse the icons? Like for favoriting, use the yellow one, and use the grey one for unfavoriting? (I will change the favorite icon from grey to black as an addtional commit too) |
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
commented
Oct 30, 2017
Member
@danxuliu scratch that, fixed it myself ;) Thanks for the pointer! |
jancborchardt
approved these changes
Oct 30, 2017
danxuliu
commented
Oct 31, 2017
MemberAuthor
Glad to help ;-)
Music to my ears :-P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested by @jancborchardt.
Before:
After:
