Uh oh!
There was an error while loading. Please reload this page.
Re-optimize and clean up settings, social and logo icons #7209 - #7231
Merged
Conversation
Signed-off-by: Marin Treselj <marin@pixelipo.com>
Signed-off-by: Marin Treselj <marin@pixelipo.com>
skjnldsv
approved these changes
Nov 20, 2017
Codecov Report
@@ Coverage Diff @@## master #7231 +/- ##
=========================================
Coverage 50.84% 50.84% Complexity 24547 24547 =========================================
Files 1585 1585 Lines 93801 93801 Branches 1354 1354 =========================================
Hits 47697 47697 Misses 46104 46104 |
MorrisJobke
approved these changes
Nov 20, 2017
skjnldsv
commented
Nov 20, 2017
Member
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've screwed up #7209 with rebase so, here it is again...
I've discovered a whole set of icons in settings app that needed to be fixed (mostly I just replaced them with already optimized icons found in core/img/* folders).
I've also fixed social icons as well as logo and favicon SVGs. Those last ones are quite critical, so test those carefully.
@nextcloud/designers
(finally) Fixes#4076