Skip to content

[stable12] only replace permission popupmenu - #7259

Merged
MorrisJobke merged 1 commit into
stable12from
7211-stable12
Nov 23, 2017
Merged

[stable12] only replace permission popupmenu#7259
MorrisJobke merged 1 commit into
stable12from
7211-stable12

Conversation

@blizzz

Copy link
Copy Markdown
Member

Backport of #7211

the contacts popovermenu is also present and is being replaces, ending
up in two permission popupmenus with checkboxes duplicating the id,
breaking further permission changes.
plus, fixing a selector
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfection

@codecov

codecovBot commented Nov 23, 2017

Copy link
Copy Markdown

Codecov Report

Merging #7259 into stable12 will increase coverage by <.01%.
The diff coverage is 33.33%.

@@ Coverage Diff @@## stable12 #7259 +/- ##
==============================================
+ Coverage 53.79% 53.79% +<.01% 
Complexity 22590 22590 ==============================================
Files 1384 1384 Lines 86666 86666 Branches 1329 1329 ==============================================
+ Hits 46620 46624 +4 + Misses 40046 40042 -4
Impacted FilesCoverage ΔComplexity Δ
core/js/sharedialogshareelistview.js44.91% <33.33%> (ø)0 <0> (ø)⬇️
lib/private/Files/Cache/Propagator.php94.93% <0%> (-1.27%)16% <0%> (ø)
lib/private/Server.php84.68% <0%> (-0.13%)121% <0%> (ø)
core/js/js.js61.83% <0%> (+0.55%)0% <0%> (ø)⬇️
lib/private/Security/CertificateManager.php92.07% <0%> (+0.99%)39% <0%> (ø)⬇️

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
MorrisJobke merged commit 4a4cf26 into stable12Nov 23, 2017
@MorrisJobke
MorrisJobke deleted the 7211-stable12 branch November 23, 2017 12:00
@MorrisJobkeMorrisJobke mentioned this pull request Nov 23, 2017
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@blizzz@MorrisJobke@skjnldsv