Skip to content

Remove unused checkCode method - #7273

Merged
MorrisJobke merged 1 commit into
masterfrom
remove-unused-code
Nov 24, 2017
Merged

Remove unused checkCode method#7273
MorrisJobke merged 1 commit into
masterfrom
remove-unused-code

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

Found while working on #7264

I could not spot any usage of this code and also no unit test. So I guess this is good to go.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@codecov

codecovBot commented Nov 24, 2017

Copy link
Copy Markdown

Codecov Report

Merging #7273 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #7273 +/- ##
============================================
+ Coverage 50.86% 50.86% +<.01% + Complexity 24550 24548 -2 
============================================
Files 1585 1585 Lines 93811 93805 -6 Branches 1354 1354 ============================================
+ Hits 47716 47717 +1 + Misses 46095 46088 -7
Impacted FilesCoverage ΔComplexity Δ
lib/private/Installer.php52.28% <ø> (+1.07%)73 <0> (-2)⬇️
lib/private/Server.php83.19% <0%> (-0.12%)126% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php72.53% <0%> (+0.24%)136% <0%> (ø)⬇️
lib/private/Security/CertificateManager.php92.07% <0%> (+0.99%)39% <0%> (ø)⬇️

@LukasReschkeLukasReschke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kill it with 🔥 😉

@MorrisJobke
MorrisJobke merged commit 44adcad into masterNov 24, 2017
@MorrisJobke
MorrisJobke deleted the remove-unused-code branch November 24, 2017 14:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke@rullzer@LukasReschke