Uh oh!
There was an error while loading. Please reload this page.
Update login filter when user filter was newly generated - #7321
Merged
Conversation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Codecov Report
@@ Coverage Diff @@## master #7321 +/- ##
============================================
+ Coverage 50.86% 50.86% +<.01%
Complexity 24538 24538 ============================================
Files 1584 1584 Lines 93794 93794 Branches 1358 1358 ============================================
+ Hits 47705 47706 +1 + Misses 46089 46088 -1
|
blizzz
commented
Dec 7, 2017
MemberAuthor
ping? |
rullzer
approved these changes
Dec 8, 2017
LukasReschke
approved these changes
Dec 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Login filter operates in assisted mode, changes to the user filter should also always trigger its update, because it utilizes it. It happens that admins forget to revisit the login filter which would trigger the update otherwise.
In manual mode, the login filter is not touched.