Skip to content

don't create sorter instances when none was requested - #7324

Merged
rullzer merged 1 commit into
masterfrom
no-sorters-no-instances
Dec 11, 2017
Merged

don't create sorter instances when none was requested#7324
rullzer merged 1 commit into
masterfrom
no-sorters-no-instances

Conversation

@blizzz

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzzblizzz added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Nov 28, 2017
@blizzzblizzz added this to the Nextcloud 13 milestone Nov 28, 2017
@codecov

codecovBot commented Nov 28, 2017

Copy link
Copy Markdown

Codecov Report

Merging #7324 into master will increase coverage by <.01%.
The diff coverage is 83.33%.

@@ Coverage Diff @@## master #7324 +/- ##
============================================
+ Coverage 50.86% 50.86% +<.01% - Complexity 24538 24539 +1 
============================================
Files 1584 1584 Lines 93794 93795 +1 Branches 1358 1358 ============================================
+ Hits 47705 47706 +1 
Misses 46089 46089
Impacted FilesCoverage ΔComplexity Δ
core/Controller/AutoCompleteController.php76.47% <83.33%> (+0.71%)6 <0> (+1)⬆️
apps/files_trashbin/lib/Expiration.php90.32% <0%> (-1.62%)29% <0%> (ø)
lib/private/Server.php82.62% <0%> (-0.12%)126% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php72.53% <0%> (+0.24%)136% <0%> (ø)⬇️
lib/private/Security/CertificateManager.php92.07% <0%> (+0.99%)39% <0%> (ø)⬇️

@MorrisJobkeMorrisJobke mentioned this pull request Dec 8, 2017
28 tasks
@rullzer
rullzer merged commit c1fcd6f into masterDec 11, 2017
@rullzer
rullzer deleted the no-sorters-no-instances branch December 11, 2017 14:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@blizzz@rullzer@MorrisJobke