Uh oh!
There was an error while loading. Please reload this page.
Allow to skip data dir permission checks by config - #7347
Merged
Conversation
Enables installation on services that don't allow/support permission changes. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Codecov Report
@@ Coverage Diff @@## master #7347 +/- ##
============================================
+ Coverage 50.86% 51.79% +0.92% + Complexity 24541 23389 -1152
============================================
Files 1584 1429 -155 Lines 93804 81026 -12778 Branches 1358 0 -1358 ============================================
- Hits 47712 41964 -5748 + Misses 46092 39062 -7030
|
karlitschek
commented
Nov 30, 2017
Member
nice 👍 please also backport |
darkneo29
commented
Nov 30, 2017
Does backport mean work on existing installs? |
icewind1991
approved these changes
Nov 30, 2017
MorrisJobke
commented
Dec 1, 2017
Member
Let me do the backport |
MorrisJobke
commented
Dec 1, 2017
Member
Backport is in #7362 |
jospoortvliet
commented
Dec 1, 2017
Member
@darkneo29 backporting means porting the code back to older releases. So this was for master, if you want it on 12, it has to be turned into a patch that applies there... Sometimes trivial, sometimes near impossible 💃 |
darkneo29
commented
Dec 31, 2017
Need a hand if possible. Reinstalled Nextcloud and added 'check_data_directory_permissions' => true, to line 39 on my config.php file. same error... |
jarofgreen
commented
Jan 1, 2018
@darkneo29 I don't think it's been released into V12 yet. Looks like it'll be in V12.0.5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #3245
@jarofgreen@tobru@tilosp@darkneo29 can you confirm?