Uh oh!
There was an error while loading. Please reload this page.
check userExists later, saves lookups for appData_INSTANCEID userids - #7361
Merged
Conversation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
MorrisJobke
approved these changes
Dec 1, 2017
rullzer
approved these changes
Dec 1, 2017
Codecov Report
@@ Coverage Diff @@## master #7361 +/- ##
============================================
- Coverage 50.91% 50.78% -0.14% - Complexity 24698 24778 +80
============================================
Files 1586 1586 Lines 94113 94358 +245 Branches 1361 1361 ============================================
- Hits 47921 47920 -1 - Misses 46192 46438 +246
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The easy and cheap check should be preferred. No need to request other user backends unnecessarily. For instance, I observed it was queried for appdata_$INSTANCEID.