Let the admin configure the default share permissions by schiessle · Pull Request #7363 · nextcloud/server

schiessle · 2017-12-01T11:01:10Z

Let the admin configure the default share permissions

Possible look:

or (currently implemented)

schiessle · 2017-12-01T12:46:24Z

@jancborchardt please have a look at the two screenshots above. What do you prefer? Or something complete different? (It is about the "default share permissions")

codecov · 2017-12-01T14:25:11Z

Codecov Report

Merging #7363 into master will increase coverage by <.01%.
The diff coverage is 71.11%.

@@ Coverage Diff @@## master #7363 +/- ##
============================================
+ Coverage 51.88% 51.89% +<.01% - Complexity 25394 25396 +2 
============================================
Files 1603 1603 Lines 95214 95249 +35 Branches 1379 1380 +1 ============================================
+ Hits 49403 49427 +24 - Misses 45811 45822 +11

Impacted Files	Coverage Δ	Complexity Δ
lib/private/TemplateLayout.php	`0% <0%> (ø)`	`48 <0> (ø)`	⬇️
core/Controller/OCJSController.php	`0% <0%> (ø)`	`2 <0> (ø)`	⬇️
core/js/js.js	`66.11% <0%> (-0.15%)`	`0 <0> (ø)`
settings/templates/settings/admin/sharing.php	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
lib/private/Template/JSConfigHelper.php	`0% <0%> (ø)`	`17 <0> (ø)`	⬇️
core/js/shareitemmodel.js	`88.14% <100%> (+0.64%)`	`0 <0> (ø)`	⬇️
lib/private/Settings/Manager.php	`65% <100%> (ø)`	`42 <0> (ø)`	⬇️
apps/files_sharing/lib/Capabilities.php	`87.8% <100%> (+0.3%)`	`5 <0> (ø)`	⬇️
...iles_sharing/lib/Controller/ShareAPIController.php	`68.34% <82.14%> (+0.65%)`	`156 <0> (+1)`	⬆️
lib/private/Settings/Admin/Sharing.php	`84% <84.21%> (-8.86%)`	`6 <2> (+1)`
... and 3 more

jancborchardt · 2017-12-11T18:30:08Z

Do we still want to stick to this complicated CRUD-mechanic? I thought at some point we only do two permissions:

Can edit
Can reshare

schiessle · 2018-02-08T15:04:21Z

Since Nextcloud 13 is out I think now it is the right time to pick this up, looking forward to your reviews

MorrisJobke · 2018-02-08T15:59:38Z

Since Nextcloud 13 is out I think now it is the right time to pick this up, looking forward to your reviews

First of all: looking forward for your merge conflict fixes 😜 😉

schiessle · 2018-02-09T20:02:45Z

@MorrisJobke done... now it is your turn 😉

jancborchardt · 2018-02-12T16:21:05Z

What about my comment above? "Can edit", "Can reshare" should be the permissions, none other.

schiessle · 2018-02-13T15:25:10Z

What about my comment above? "Can edit", "Can reshare" should be the permissions, none other.

@jancborchardt I think it is a bit out of context. I'm completely open for simplifying the permissions. But this is one is just about making the default permissions configurable.

schiessle · 2018-02-23T12:46:16Z

waiting for a second review... Would be great to get this finally in before we have to rebase it again and again. Thanks!

MorrisJobke · 2018-02-26T16:42:12Z

@rullzer @nickvergessen @skjnldsv Review would be nice :)

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

rullzer · 2018-02-27T11:37:17Z

I rebased to make sure it all still works. Fails somehow. I'll look into the why....

rullzer · 2018-02-27T11:49:33Z

Ah was just cached stuff. Works like a charm.

schiessle added 2. developing Work in progress downstream feature: sharing labels Dec 1, 2017

schiessle added this to the Nextcloud 13 milestone Dec 1, 2017

schiessle force-pushed the default-share-perms branch 5 times, most recently from 97db685 to c09d4d9Compare December 1, 2017 15:56

schiessle requested review from MorrisJobke, blizzz and rullzer December 1, 2017 16:11

schiessle added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 1, 2017

schiessle requested a review from jancborchardt December 1, 2017 16:11

schiessle modified the milestones: Nextcloud 13, Nextcloud 14 Dec 4, 2017

MorrisJobke mentioned this pull request Dec 9, 2017
13.0.0 beta 2 #7425
Merged
28 tasks

This was referenced Feb 7, 2018
Restrict default permission to READ for sharebymail. #8204
Closed
Change default permissions on sharebymail #8186
Closed

schiessle force-pushed the default-share-perms branch 2 times, most recently from 4fe6b04 to 50e9aabCompare February 9, 2018 20:02

MorrisJobke approved these changes Feb 15, 2018
View reviewed changes

MorrisJobke requested review from danxuliu and nickvergessen February 15, 2018 10:07

MorrisJobke mentioned this pull request Feb 15, 2018
Show indeterminate status for sharing permissions #8371
Closed

MorrisJobke requested a review from skjnldsv February 26, 2018 16:41

schiessleand others added 7 commits February 27, 2018 12:29

expose capabilities in js
7d0102b
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

add share permissions to settings page
1615312
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

improved layout of the admin settings
7741429
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

share api: use default permission of no permission is given
ebb1528
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

fix unit tests
3285bec
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

Fix share capabilities JS tests
7466468
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

Fix JSDoc
20ec034
Signed-off-by: Morris Jobke <hey@morrisjobke.de>

rullzer force-pushed the default-share-perms branch from fc1740c to 20ec034Compare February 27, 2018 11:29

rullzer approved these changes Feb 27, 2018
View reviewed changes

rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 27, 2018

MorrisJobke merged commit 7bc3c2e into masterFeb 27, 2018

MorrisJobke deleted the default-share-perms branch February 27, 2018 12:44

kimsyversen mentioned this pull request Jun 15, 2018
Customize default for the resharing option #9848
Closed

Navigation Menu

Uh oh!

Uh oh!

Let the admin configure the default share permissions - #7363

Let the admin configure the default share permissions#7363
MorrisJobke merged 7 commits into
masterfrom
default-share-perms

schiessle commented Dec 1, 2017•
edited
Loading

Uh oh!

schiessle commented Dec 1, 2017•
edited
Loading

Uh oh!

codecovBot commented Dec 1, 2017•
edited
Loading

Uh oh!

jancborchardt commented Dec 11, 2017

Uh oh!

schiessle commented Feb 8, 2018

Uh oh!

MorrisJobke commented Feb 8, 2018

Uh oh!

schiessle commented Feb 9, 2018

Uh oh!

jancborchardt commented Feb 12, 2018

Uh oh!

schiessle commented Feb 13, 2018•
edited
Loading

Uh oh!

schiessle commented Feb 23, 2018

Uh oh!

MorrisJobke commented Feb 26, 2018

Uh oh!

rullzer commented Feb 27, 2018

Uh oh!

rullzer commented Feb 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

schiessle commented Dec 1, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

schiessle commented Dec 1, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecovBot commented Dec 1, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jancborchardt commented Dec 11, 2017

Uh oh!

schiessle commented Feb 8, 2018

Uh oh!

MorrisJobke commented Feb 8, 2018

Uh oh!

schiessle commented Feb 9, 2018

Uh oh!

jancborchardt commented Feb 12, 2018

Uh oh!

schiessle commented Feb 13, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

schiessle commented Feb 23, 2018

Uh oh!

MorrisJobke commented Feb 26, 2018

Uh oh!

rullzer commented Feb 27, 2018

Uh oh!

rullzer commented Feb 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

schiessle commented Dec 1, 2017•
edited
Loading

schiessle commented Dec 1, 2017•
edited
Loading

codecovBot commented Dec 1, 2017•
edited
Loading

schiessle commented Feb 13, 2018•
edited
Loading