Skip to content

add retry wrapper when reading files from swift - #7387

Merged
rullzer merged 1 commit into
masterfrom
swift-retry
Dec 6, 2017
Merged

add retry wrapper when reading files from swift#7387
rullzer merged 1 commit into
masterfrom
swift-retry

Conversation

@icewind1991

@icewind1991icewind1991 commented Dec 4, 2017

Copy link
Copy Markdown
Member

Fixes#7382

Smooth out the behaviour of the stream

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added this to the Nextcloud 13 milestone Dec 4, 2017
@codecov

codecovBot commented Dec 4, 2017

Copy link
Copy Markdown

Codecov Report

Merging #7387 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #7387 +/- ##
============================================
+ Coverage 50.91% 50.91% +<.01% 
Complexity 24699 24699 ============================================
Files 1586 1586 Lines 94116 94116 Branches 1361 1361 ============================================
+ Hits 47920 47921 +1 + Misses 46196 46195 -1
Impacted FilesCoverage ΔComplexity Δ
apps/files_external/lib/Lib/Storage/Swift.php0% <0%> (ø)113 <0> (ø)⬇️
lib/private/Files/ObjectStore/Swift.php0% <0%> (ø)39 <0> (ø)⬇️
apps/files_trashbin/lib/Trashbin.php72.53% <0%> (+0.24%)136% <0%> (ø)⬇️

@rullzer

Copy link
Copy Markdown
Member

👍 from @vilisseranen in #7382 (comment)

@rullzerrullzer added 3. to review Waiting for reviews bug labels Dec 6, 2017

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to do the trick!

@rullzer

Copy link
Copy Markdown
Member

@icewind1991 should this be backported to 12?

@rullzer
rullzer merged commit cde5861 into masterDec 6, 2017
@rullzer
rullzer deleted the swift-retry branch December 6, 2017 07:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@icewind1991@rullzer