Skip to content

ensure that users are cached when they are retrieved - #7418

Merged
MorrisJobke merged 2 commits into
masterfrom
ldap-fix-cache-retrieved-user
Dec 11, 2017
Merged

ensure that users are cached when they are retrieved#7418
MorrisJobke merged 2 commits into
masterfrom
ldap-fix-cache-retrieved-user

Conversation

@blizzz

Copy link
Copy Markdown
Member

this got lost during the performance changes (sic!), but now comes with a unit test 😊

Basically you see an additional request on LDAP after getting a user list (even on login) that checks for existence of the user. The data is fresh from LDAP however and can be cached right away to avoid this additional requests.

@nextcloud/ldap

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@codecov

codecovBot commented Dec 7, 2017

Copy link
Copy Markdown

Codecov Report

Merging #7418 into master will decrease coverage by 23.65%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #7418 +/- ##
=============================================
- Coverage 50.93% 27.27% -23.66% - Complexity 24710 24712 +2 
=============================================
Files 1586 1522 -64 Lines 94144 86415 -7729 Branches 1364 0 -1364 =============================================
- Hits 47948 23568 -24380 - Misses 46196 62847 +16651
Impacted FilesCoverage ΔComplexity Δ
apps/user_ldap/lib/Helper.php29% <ø> (-9%)34 <0> (ø)
apps/user_ldap/lib/Access.php0% <0%> (-26.29%)315 <0> (+2)
lib/private/DB/OCSqlitePlatform.php0% <0%> (-100%)5% <0%> (ø)
lib/private/Files/Cache/Wrapper/JailPropagator.php0% <0%> (-100%)1% <0%> (ø)
lib/private/SystemTag/ManagerFactory.php0% <0%> (-100%)3% <0%> (ø)
lib/private/Share20/Hooks.php0% <0%> (-100%)3% <0%> (ø)
apps/files_trashbin/lib/Command/Expire.php0% <0%> (-100%)3% <0%> (ø)
apps/files_trashbin/lib/Hooks.php0% <0%> (-100%)3% <0%> (ø)
...yBuilder/FunctionBuilder/SqliteFunctionBuilder.php0% <0%> (-100%)1% <0%> (ø)
apps/user_ldap/lib/LDAPProviderFactory.php0% <0%> (-100%)2% <0%> (ø)
... and 443 more

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
blizzzforce-pushed the ldap-fix-cache-retrieved-user branch from 7310724 to 27f14eeCompareDecember 7, 2017 21:47
@blizzzblizzz mentioned this pull request Dec 8, 2017
28 tasks

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please!

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and still works 👍

@MorrisJobke
MorrisJobke merged commit 7fdc4b5 into masterDec 11, 2017
@MorrisJobke
MorrisJobke deleted the ldap-fix-cache-retrieved-user branch December 11, 2017 14:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@blizzz@rullzer@MorrisJobke