Skip to content

App content list fixes - #7431

Merged
rullzer merged 3 commits into
masterfrom
app-content-list-fixes
Dec 11, 2017
Merged

App content list fixes#7431
rullzer merged 3 commits into
masterfrom
app-content-list-fixes

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

Since I'm an idiot, I haven't implemented the proper scrolling of the app list... 🙈
You can test this with nextcloud/contacts#438 and make two birds with one stone by reviewing both 😝

@skjnldsvskjnldsv added 3. to review Waiting for reviews design Design, UI, UX, etc. high labels Dec 8, 2017
@skjnldsvskjnldsv added this to the Nextcloud 13 milestone Dec 8, 2017
@skjnldsvskjnldsv self-assigned this Dec 8, 2017
@skjnldsvskjnldsv mentioned this pull request Dec 8, 2017
28 tasks
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@codecov

codecovBot commented Dec 11, 2017

Copy link
Copy Markdown

Codecov Report

Merging #7431 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #7431 +/- ##
============================================
+ Coverage 51.08% 51.08% +<.01% - Complexity 24858 24865 +7 
============================================
Files 1596 1596 Lines 94590 94608 +18 Branches 1367 1367 ============================================
+ Hits 48317 48335 +18 
Misses 46273 46273
Impacted FilesCoverage ΔComplexity Δ
lib/private/Files/Node/HookConnector.php94.59% <0%> (-1.36%)19% <0%> (ø)
lib/private/Security/CertificateManager.php91.08% <0%> (-1%)39% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php72.28% <0%> (-0.25%)136% <0%> (ø)
lib/private/Files/Filesystem.php69.66% <0%> (ø)120% <0%> (ø)⬇️
lib/private/Server.php82.04% <0%> (+0.06%)133% <0%> (+5%)⬆️
lib/private/legacy/util.php58.34% <0%> (+0.16%)230% <0%> (ø)⬇️
lib/private/Files/View.php84.38% <0%> (+0.16%)373% <0%> (+2%)⬆️
lib/private/Files/Cache/Propagator.php96.2% <0%> (+1.26%)16% <0%> (ø)⬇️
lib/private/AvatarManager.php71.42% <0%> (+9.52%)4% <0%> (ø)⬇️

@MorrisJobke

Copy link
Copy Markdown
Member

Rebased to check if CI runs fine.

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works - even in Edge and IE11 😉

@skjnldsv

skjnldsv commented Dec 11, 2017

Copy link
Copy Markdown
MemberAuthor

Wait before merging

EDIT: GO GO GO

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to do the trick

@rullzer
rullzer merged commit bd80795 into masterDec 11, 2017
@rullzer
rullzer deleted the app-content-list-fixes branch December 11, 2017 19:02
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

🙇

@jancborchardt

Copy link
Copy Markdown
Member

Good stuff @skjnldsv! :) (Am currently crawling through issues after the week vacation :D)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsdesignDesign, UI, UX, etc.highstandardization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@MorrisJobke@jancborchardt@rullzer