Skip to content

Set autocomplete on share password input - #7461

Merged
MorrisJobke merged 1 commit into
masterfrom
fix_6821
Dec 12, 2017
Merged

Set autocomplete on share password input#7461
MorrisJobke merged 1 commit into
masterfrom
fix_6821

Conversation

@rullzer

@rullzerrullzer commented Dec 12, 2017

Copy link
Copy Markdown
Member

@rullzer
Set autocomplete on share password input
4577247
Fixes#6821
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added this to the Nextcloud 13 milestone Dec 12, 2017
ChristophWurst
ChristophWurst approved these changes Dec 12, 2017
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@blizzzblizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 12, 2017
@codecov

codecovBot commented Dec 12, 2017•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7461 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #7461 +/- ##
=========================================
Coverage 51.11% 51.11% Complexity 24900 24900 =========================================
Files 1601 1601 Lines 94772 94772 Branches 1367 1367 =========================================
Hits 48438 48438 Misses 46334 46334
Impacted FilesCoverage ΔComplexity Δ
core/js/sharedialoglinkshareview.js59.21% <ø> (ø)0 <0> (ø)⬇️
lib/private/Security/CertificateManager.php91.08% <0%> (-1%)39% <0%> (ø)
lib/private/Server.php81.62% <0%> (+0.11%)133% <0%> (ø)⬇️

@MorrisJobke
MorrisJobke merged commit 7ad746a into masterDec 12, 2017
@MorrisJobke
MorrisJobke deleted the fix_6821 branch December 12, 2017 11:32
This was referenced Dec 12, 2017
Merged
Closed
@skjnldsvskjnldsv mentioned this pull request May 19, 2018
Closed
@MorrisJobkeMorrisJobke mentioned this pull request Jun 21, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@blizzzblizzzblizzz approved these changes
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke
@schiessleschiessleAwaiting requested review from schiessle
@danxuliudanxuliuAwaiting requested review from danxuliu

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementfeature: sharing

Projects

None yet

Milestone

Nextcloud 13

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer@ChristophWurst@blizzz@MorrisJobke