Uh oh!
There was an error while loading. Please reload this page.
Dynamic control bar width - #7484
Conversation
Signed-off-by: Marin Treselj <marin@pixelipo.com>
skjnldsv
commented
Dec 13, 2017
It's not going to float on top anymore on long scrolling lists though! :/ |
pixelipo
commented
Dec 13, 2017
Yeah, I know :( |
MorrisJobke
commented
Dec 13, 2017
cc @nextcloud/designers |
jancborchardt
commented
Dec 14, 2017
:/ can we make both work? Cause we basically would trade "grid view switch not visible when there's a sidebar" with "neither breadcrumbs, upload, nor grid view visible when scrolled". |
Signed-off-by: Marin Treselj <marin@pixelipo.com>
| #controls { | ||
| box-sizing: border-box; | ||
| position: relative; | ||
| position: sticky; |
There was a problem hiding this comment.
Sadly this is not supported in IE11 😢
There was a problem hiding this comment.
@MorrisJobke this will have really a minor effect for IE11 users (I think), no real degradation, so maybe it's still worth it? @jancborchardt ?
There was a problem hiding this comment.
Thanks @MorrisJobke - I would test it but I don't have a Windows computer available...
pixelipo
commented
Dec 19, 2017
Turns out, we can, @jancborchardt ! I've made a commit here that fixes both problems :) @skjnldsv@MorrisJobke please give feedback, but I suggest we merge this to the parent branch |
pixelipo
commented
Dec 19, 2017
One thing that might be worth noting:
Windows 7 is already in the "Extended support" (only security fixes). I'm not sure if we are following OS support, but if so, IE11 should still be supported by us, but only on the "good enough" level. This, of course, takes no account of Nextcloud's business, I'm obviously only speaking (daydreaming?) as a developer - if there are big organizations that rely on NC and use IE11, than non of that matters. |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
commented
Dec 20, 2017
@skjnldsv Could we merge this? I added little fix (removed the z-index on the controls) to fix the behaviour in Safari and IE/Edge. (was working in Chrome) |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
skjnldsv
commented
Dec 20, 2017
pixelipo
commented
Dec 20, 2017
skjnldsv
commented
Dec 20, 2017
@pixelipo yup, done :) |

Proposed solution for the issue found in #7478 by @MorrisJobke