Uh oh!
There was an error while loading. Please reload this page.
disable password confirmation with SSO - #7487
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@## master #7487 +/- ##
============================================
+ Coverage 51.17% 51.18% +0.01% - Complexity 24887 24892 +5
============================================
Files 1601 1602 +1 Lines 94752 94774 +22 Branches 1368 1369 +1 ============================================
+ Hits 48489 48510 +21 - Misses 46263 46264 +1
|
schiessleforce-pushed
the
no-password-confirm-with-sso
branch
2 times, most recently
from
December 13, 2017 15:18
d4a047b to
eaa8d08Compareblizzz
commented
Jan 2, 2018
Member
Can we have unit tests for the middle ware that test positive as well as negative cases? |
rullzer
commented
Jan 2, 2018
Member
Pfff right. I knew I disliked all this functionality in 1 middleware. I'd like to just add an additional one that we can properly test. |
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
rullzerforce-pushed
the
no-password-confirm-with-sso
branch
from
January 2, 2018 20:33
eaa8d08 to
763874aComparerullzer
commented
Jan 2, 2018
Member
|
Add tests Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
no-password-confirm-with-sso
branch
from
January 2, 2018 20:58
763874a to
5705014Comparerullzer
approved these changes
Jan 3, 2018
blizzz
reviewed
Jan 3, 2018
| $lastConfirm = (int) $this->session->get('last-password-confirm'); | ||
| // we can't check the password against a SAML backend, so skip password confirmation in this case | ||
| if ($backendClassName !== 'user_saml' && $lastConfirm < ($this->timeFactory->getTime() - (30 * 60 + 15))) { // allow 15 seconds delay |
Member
There was a problem hiding this comment.
I don't like it is hard-coded… if we can test for an instance (→ OCP) that would be much better. Perhaps for 14, for now (and backporting?) good enough.
blizzz
approved these changes
Jan 3, 2018
blizzz
left a comment
Member
There was a problem hiding this comment.
cannot test, but code looks good and i am confident with the unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable password confirmation in case of single-sign-on.
In case of SSO password confirmation doesn't work because Nextcloud can't check the users password.