Skip to content

Use proper authorative-autoloader for app autoloaders - #7502

Merged
rullzer merged 1 commit into
masterfrom
authorative_classmaps_for_apps
Dec 14, 2017
Merged

Use proper authorative-autoloader for app autoloaders#7502
rullzer merged 1 commit into
masterfrom
authorative_classmaps_for_apps

Conversation

@rullzer

Copy link
Copy Markdown
Member

Because I'm an idiot I used some non existing keyword to try to set an authoritative classmap.

I noticed we were spending an insane amount of time in findFileWithExtention. This should make that a lot better.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov

codecovBot commented Dec 14, 2017

Copy link
Copy Markdown

Codecov Report

Merging #7502 into master will increase coverage by 0.05%.
The diff coverage is 5.26%.

@@ Coverage Diff @@## master #7502 +/- ##
============================================
+ Coverage 51.11% 51.16% +0.05% + Complexity 24903 24865 -38 
============================================
Files 1601 1601 Lines 94778 94683 -95 Branches 1368 1368 ============================================
+ Hits 48445 48446 +1 + Misses 46333 46237 -96
Impacted FilesCoverage ΔComplexity Δ
apps/files/composer/composer/autoload_real.php0% <0%> (ø)9 <0> (-2)⬇️
.../files_sharing/composer/composer/autoload_real.php0% <0%> (ø)9 <0> (-2)⬇️
...tedfilesharing/composer/composer/autoload_real.php0% <0%> (ø)9 <0> (-2)⬇️
apps/oauth2/composer/composer/autoload_real.php0% <0%> (ø)9 <0> (-2)⬇️
apps/user_ldap/composer/composer/autoload_real.php0% <0%> (ø)9 <0> (-2)⬇️
...pps/systemtags/composer/composer/autoload_real.php0% <0%> (ø)9 <0> (-2)⬇️
...ps/sharebymail/composer/composer/autoload_real.php0% <0%> (ø)9 <0> (-2)⬇️
...pps/federation/composer/composer/autoload_real.php0% <0%> (ø)9 <0> (-2)⬇️
apps/dav/composer/composer/autoload_real.php0% <0%> (ø)9 <0> (-2)⬇️
...rver_connector/composer/composer/autoload_real.php0% <0%> (ø)9 <0> (-2)⬇️
... and 11 more

@MorrisJobke

Copy link
Copy Markdown
Member

Is the classmap also dumped for those apps? 🤔

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍
bildschirmfoto 2017-12-14 um 09 23 52

@MorrisJobke

Copy link
Copy Markdown
Member

Is the classmap also dumped for those apps? 🤔

Just checked and yes it is 😉

@skjnldsv

Copy link
Copy Markdown
Member

I'll get the whip!!! 😠

@rullzer
rullzer merged commit b5d9c3b into masterDec 14, 2017
@rullzer
rullzer deleted the authorative_classmaps_for_apps branch December 14, 2017 09:01
@MorrisJobkeMorrisJobke mentioned this pull request Jan 2, 2018
30 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugenhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@MorrisJobke@skjnldsv