Skip to content

Reduce length of md5 in scss caching - #7504

Merged
MorrisJobke merged 3 commits into
masterfrom
shorter-css-prefixes
Dec 14, 2017
Merged

Reduce length of md5 in scss caching#7504
MorrisJobke merged 3 commits into
masterfrom
shorter-css-prefixes

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Dec 14, 2017

Copy link
Copy Markdown
Member

Easier to debug.

BeforeAfter
kazam_screenshot_00011kazam_screenshot_00010

@skjnldsvskjnldsv added this to the Nextcloud 13 milestone Dec 14, 2017
@skjnldsvskjnldsv self-assigned this Dec 14, 2017
rullzer
rullzer approved these changes Dec 14, 2017
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me

@MorrisJobke

MorrisJobke commented Dec 14, 2017

Copy link
Copy Markdown
Member

Unit test failures.

@skjnldsv
Reduce length of md5 in scss caching
f2d5927
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@codecov

codecovBot commented Dec 14, 2017•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7504 into master will decrease coverage by 16.39%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #7504 +/- ##
============================================
- Coverage 51.16% 34.77% -16.4% 
Complexity 24865 24865 ============================================
Files 1601 1601 Lines 94683 94683 Branches 1368 1368 ============================================
- Hits 48446 32923 -15523 - Misses 46237 61760 +15523
Impacted FilesCoverage ΔComplexity Δ
lib/private/Template/SCSSCacher.php6.34% <0%> (-63.5%)36 <0> (ø)
lib/private/Files/ObjectStore/Mapper.php0% <0%> (-100%)2% <0%> (ø)
lib/private/App/AppStore/Bundles/Bundle.php0% <0%> (-100%)2% <0%> (ø)
...ddleware/Security/Exceptions/NotAdminException.php0% <0%> (-100%)1% <0%> (ø)
...Check/Iterator/ExcludeFileByNameFilterIterator.php0% <0%> (-100%)2% <0%> (ø)
apps/files_trashbin/appinfo/app.php0% <0%> (-100%)0% <0%> (ø)
apps/dav/lib/CalDAV/Activity/Filter/Calendar.php0% <0%> (-100%)7% <0%> (ø)
lib/private/App/CodeChecker/EmptyCheck.php0% <0%> (-100%)6% <0%> (ø)
lib/public/AppFramework/Http/DownloadResponse.php0% <0%> (-100%)1% <0%> (ø)
apps/user_ldap/lib/Settings/Section.php0% <0%> (-100%)5% <0%> (ø)
... and 515 more

@skjnldsv
Test fixes
158f442
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Test fixes 2
b8778b0
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv

skjnldsv commented Dec 14, 2017

Copy link
Copy Markdown
MemberAuthor

Test failure is unrelated, merging.

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 14, 2017
@MorrisJobke
MorrisJobke merged commit b19b137 into masterDec 14, 2017
@MorrisJobke
MorrisJobke deleted the shorter-css-prefixes branch December 14, 2017 11:12
@MorrisJobkeMorrisJobke mentioned this pull request Jan 2, 2018
Merged
30 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@LukasReschkeLukasReschkeAwaiting requested review from LukasReschke
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishfeature: scss

Projects

None yet

Milestone

Nextcloud 13

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@MorrisJobke@rullzer