Do not update apps if it comes from git by skjnldsv · Pull Request #7505 · nextcloud/server

skjnldsv · 2017-12-14T08:53:34Z

We had a lot of issues as devs by those auto update...

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

MorrisJobke · 2017-12-14T08:59:14Z


+ if ($this->isInstalledFromGit($appId) === true) {
+ return false;
+ }


Could we move this check one up ... just to return earlier in the method?

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

MorrisJobke

Tested and works 👍

rullzer

Works for the 99% use case for me! Lets do this.

ChristophWurst · 2017-12-14T09:25:18Z

What happens if a developer accidentally packages the .git dir? Does that mean the app will never be updated again? 🙈

skjnldsv · 2017-12-14T09:27:54Z

@ChristophWurst Yup!
We should add a test in the appstore for that I think! :)

MorrisJobke · 2017-12-14T09:44:56Z

We should add a test in the appstore for that I think! :)

nextcloud/appstore#537

codecov · 2017-12-14T09:46:38Z

Codecov Report

Merging #7505 into master will increase coverage by 0.05%.
The diff coverage is 75%.

@@ Coverage Diff @@## master #7505 +/- ##
============================================
+ Coverage 51.11% 51.16% +0.05% + Complexity 24903 24868 -35 
============================================
Files 1601 1601 Lines 94778 94691 -87 Branches 1368 1368 ============================================
+ Hits 48445 48452 +7 + Misses 46333 46239 -94

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Installer.php	`58.17% <75%> (+0.52%)`	`77 <2> (+3)`	⬆️
apps/files_trashbin/lib/Expiration.php	`90.32% <0%> (-1.62%)`	`29% <0%> (ø)`
lib/private/Server.php	`80.9% <0%> (-0.12%)`	`134% <0%> (ø)`
...rver_connector/composer/composer/autoload_real.php	`0% <0%> (ø)`	`9% <0%> (-2%)`	⬇️
...pps/encryption/composer/composer/autoload_real.php	`0% <0%> (ø)`	`9% <0%> (-2%)`	⬇️
...files_versions/composer/composer/autoload_real.php	`0% <0%> (ø)`	`9% <0%> (-2%)`	⬇️
apps/oauth2/composer/composer/autoload_real.php	`0% <0%> (ø)`	`9% <0%> (-2%)`	⬇️
.../files_sharing/composer/composer/autoload_real.php	`0% <0%> (ø)`	`9% <0%> (-2%)`	⬇️
...tenotification/composer/composer/autoload_real.php	`0% <0%> (ø)`	`9% <0%> (-2%)`	⬇️
apps/testing/composer/composer/autoload_real.php	`0% <0%> (ø)`	`9% <0%> (-2%)`	⬇️
... and 14 more

skjnldsv · 2017-12-14T09:48:42Z

We could also refuse to install an app if it has a .git in it ;)

MorrisJobke · 2017-12-14T09:55:05Z

What happens if a developer accidentally packages the .git dir? Does that mean the app will never be updated again? 🙈

@ChristophWurst @skjnldsv Another idea: only reject this if the nextcloud itself is also a git clone (update channel === git) 😉

MorrisJobke · 2017-12-14T10:03:56Z

@BernhardPosselt Mentioned that we maybe should also add checks for other typical VCS systems and have a blacklist:

SVN
HG
bazaar
git

Anything else?

skjnldsv · 2017-12-14T10:11:02Z

@ChristophWurst @skjnldsv Another idea: only reject this if the nextcloud itself is also a git clone (update channel === git) 😉

@MorrisJobke I would say no, because I sometimes uses default apps without using their git repo :)

jancborchardt · 2017-12-14T13:37:28Z

cc @Henni for review as he also had this issue :)

MorrisJobke · 2017-12-18T12:43:55Z

Okay - let's go for the .git folder for now and check if this is already enough.

Do not update apps if it comes from git
cca8744
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

skjnldsv added 3. to review Waiting for reviews feature: apps management high technical debt 🧱 🤔🚀 labels Dec 14, 2017

skjnldsv added this to the Nextcloud 13 milestone Dec 14, 2017

skjnldsv self-assigned this Dec 14, 2017

skjnldsv requested review from ChristophWurst, MorrisJobke, jancborchardt and rullzer December 14, 2017 08:53

MorrisJobke reviewed Dec 14, 2017
View reviewed changes

MorrisJobke mentioned this pull request Dec 14, 2017
Dev work inside apps is overwritten by marketplace app version #7011
Closed

Up check
2dbd505
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

MorrisJobke approved these changes Dec 14, 2017
View reviewed changes

MorrisJobke requested a review from blizzz December 14, 2017 09:08

rullzer approved these changes Dec 14, 2017
View reviewed changes

MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 14, 2017

ChristophWurst mentioned this pull request Dec 14, 2017
Ignore .git by default ChristophWurst/krankerl#21
Open

MorrisJobke mentioned this pull request Dec 14, 2017
Reject apps, that ship a .git dir in root nextcloud/appstore#537
Closed

MorrisJobke merged commit 97f80f5 into masterDec 18, 2017

MorrisJobke deleted the do-not-update-if-app-comes-from-git branch December 18, 2017 12:44

MorrisJobke mentioned this pull request Jan 2, 2018
13.0.0 beta 4 #7664
Merged
30 tasks

Uh oh!

Uh oh!

Conversation

skjnldsv commented Dec 14, 2017• edited by MorrisJobke Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MorrisJobkeDec 14, 2017

Choose a reason for hiding this comment

Uh oh!

skjnldsvDec 14, 2017

Choose a reason for hiding this comment

Uh oh!

MorrisJobke left a comment

Choose a reason for hiding this comment

Uh oh!

rullzer left a comment

Choose a reason for hiding this comment

Uh oh!

ChristophWurst commented Dec 14, 2017

Uh oh!

skjnldsv commented Dec 14, 2017

Uh oh!

MorrisJobke commented Dec 14, 2017

Uh oh!

codecovBot commented Dec 14, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

skjnldsv commented Dec 14, 2017

Uh oh!

MorrisJobke commented Dec 14, 2017

Uh oh!

MorrisJobke commented Dec 14, 2017

Uh oh!

skjnldsv commented Dec 14, 2017

Uh oh!

jancborchardt commented Dec 14, 2017

Uh oh!

MorrisJobke commented Dec 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

skjnldsv commented Dec 14, 2017•
edited by MorrisJobke
Loading

codecovBot commented Dec 14, 2017•
edited
Loading