Skip to content

Use cached app list - #7506

Merged
MorrisJobke merged 1 commit into
masterfrom
fix-app-cache
Dec 14, 2017
Merged

Use cached app list#7506
MorrisJobke merged 1 commit into
masterfrom
fix-app-cache

Conversation

@MorrisJobke

@MorrisJobkeMorrisJobke commented Dec 14, 2017

Copy link
Copy Markdown
Member

Followup to #7264

Before it just fetched the list again and again 🙈

@MorrisJobke
Use cached app list
54c227b
Followup to #7264
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Dec 14, 2017
@MorrisJobkeMorrisJobke added this to the Nextcloud 13 milestone Dec 14, 2017
@MorrisJobke

MorrisJobke commented Dec 14, 2017

Copy link
Copy Markdown
MemberAuthor

I also added an unit tests that check this behaviour ;)

skjnldsv
skjnldsv approved these changes Dec 14, 2017
View reviewed changes

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! ^^

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 14, 2017
@codecov

codecovBot commented Dec 14, 2017•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7506 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #7506 +/- ##
============================================
+ Coverage 51.11% 51.16% +0.05% + Complexity 24903 24865 -38 
============================================
Files 1601 1601 Lines 94778 94683 -95 Branches 1368 1368 ============================================
+ Hits 48445 48446 +1 + Misses 46333 46237 -96
Impacted FilesCoverage ΔComplexity Δ
lib/private/Installer.php57.64% <100%> (ø)74 <0> (ø)⬇️
lib/private/Server.php80.9% <0%> (-0.12%)134% <0%> (ø)
...rver_connector/composer/composer/autoload_real.php0% <0%> (ø)9% <0%> (-2%)⬇️
...pps/encryption/composer/composer/autoload_real.php0% <0%> (ø)9% <0%> (-2%)⬇️
...files_versions/composer/composer/autoload_real.php0% <0%> (ø)9% <0%> (-2%)⬇️
apps/oauth2/composer/composer/autoload_real.php0% <0%> (ø)9% <0%> (-2%)⬇️
.../files_sharing/composer/composer/autoload_real.php0% <0%> (ø)9% <0%> (-2%)⬇️
...tenotification/composer/composer/autoload_real.php0% <0%> (ø)9% <0%> (-2%)⬇️
apps/testing/composer/composer/autoload_real.php0% <0%> (ø)9% <0%> (-2%)⬇️
apps/comments/composer/composer/autoload_real.php0% <0%> (ø)9% <0%> (-2%)⬇️
... and 12 more

@MorrisJobke
MorrisJobke merged commit 1f10897 into masterDec 14, 2017
@MorrisJobke
MorrisJobke deleted the fix-app-cache branch December 14, 2017 09:45
@MorrisJobkeMorrisJobke mentioned this pull request Jan 2, 2018
Merged
30 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@schiessleschiessleAwaiting requested review from schiessle
@blizzzblizzzAwaiting requested review from blizzz

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 13

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke@rullzer@skjnldsv