Uh oh!
There was an error while loading. Please reload this page.
Add index to share_with column in the share table - #7517
Merged
Conversation
schiessle
requested review from
blizzz, icewind1991, nickvergessen and rullzerDecember 14, 2017 15:52
icewind1991
approved these changes
Dec 14, 2017
rullzer
reviewed
Dec 14, 2017
| use Symfony\Component\Console\Input\InputInterface; | ||
| use Symfony\Component\Console\Output\OutputInterface; | ||
| class AddIndexToShareTable extends Command { |
Member
There was a problem hiding this comment.
Can't we do it more generic? Like have an "create indexes" occ command. We list all the indexes that need to be added here. And just check if there already is one. If so we skip. If not we add it?
That way we can easily add more indexes later. instead of having multiple different commands (because there are some still missing I bet).
MemberAuthor
There was a problem hiding this comment.
sounds good, I will name it more generic
Codecov Report
@@ Coverage Diff @@## master #7517 +/- ##
============================================
- Coverage 51.18% 51.17% -0.02% - Complexity 24874 24881 +7
============================================
Files 1601 1602 +1 Lines 94701 94726 +25 Branches 1368 1368 ============================================
- Hits 48474 48473 -1 - Misses 46227 46253 +26
|
schiessleforce-pushed
the
add-index-to-share-table
branch
from
December 15, 2017 09:49
371bb26 to
c64884eCompareSigned-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org> Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
add-index-to-share-table
branch
from
December 18, 2017 20:16
0298fe1 to
21489d5Comparerullzer
commented
Dec 18, 2017
Member
I rebased on master. |
rullzer
approved these changes
Dec 18, 2017
rullzer
left a comment
Member
There was a problem hiding this comment.
Makes a lot of sense!
Works like a charm here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a index to share_with. This should improve the performance quite a bit as we need to query all shares with a specific user every time we set up the file system.
For updating existing instances I created a occ script instead of a automated update step because this can take quite some time for large installation.