Skip to content

Also check for empty content length - #7523

Merged
MorrisJobke merged 1 commit into
masterfrom
check_empty_content_length
Dec 15, 2017
Merged

Also check for empty content length#7523
MorrisJobke merged 1 commit into
masterfrom
check_empty_content_length

Conversation

@rullzer

Copy link
Copy Markdown
Member

My guess it this is caused by php 7.2

I was debugging the client with the https://github.com/nextcloud/end_to_end_encryption app. To encrypt a folder a PUT request is send to

<server>/ocs/v2.php/apps/end_to_end_encryption/api/v1/encrypted/<fileid>

Without this patch this will fail. Because we don't correctly get the id from the urlparameters.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov

codecovBot commented Dec 14, 2017

Copy link
Copy Markdown

Codecov Report

Merging #7523 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #7523 +/- ##
============================================
- Coverage 51.16% 51.16% -0.01% - Complexity 24865 24866 +1 
============================================
Files 1601 1601 Lines 94683 94684 +1 Branches 1368 1368 ============================================
- Hits 48446 48443 -3 - Misses 46237 46241 +4
Impacted FilesCoverage ΔComplexity Δ
lib/private/AppFramework/Http/Request.php92.7% <100%> (+0.02%)149 <0> (+1)⬆️
core/js/js.js62.98% <0%> (-0.57%)0% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php72.53% <0%> (+0.24%)136% <0%> (ø)⬇️

@MorrisJobke
MorrisJobke merged commit cfb3f44 into masterDec 15, 2017
@MorrisJobke
MorrisJobke deleted the check_empty_content_length branch December 15, 2017 09:30
@MorrisJobkeMorrisJobke mentioned this pull request Jan 2, 2018
30 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugregression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@MorrisJobke@blizzz