Uh oh!
There was an error while loading. Please reload this page.
don't use deprecated method for requesting memcache - #7531
Merged
Conversation
MorrisJobke
approved these changes
Dec 15, 2017
Codecov Report
@@ Coverage Diff @@## master #7531 +/- ##
============================================
+ Coverage 51.17% 51.18% +<.01%
Complexity 24874 24874 ============================================
Files 1601 1601 Lines 94707 94707 Branches 1368 1368 ============================================
+ Hits 48469 48473 +4 + Misses 46238 46234 -4
|
MorrisJobke
commented
Dec 15, 2017
Member
Let's also fix the other occurrences |
icewind1991
approved these changes
Dec 15, 2017
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
rullzerforce-pushed
the
ldap/createdistributed
branch
from
December 18, 2017 20:07
e2e104c to
094d419Comparerullzer
approved these changes
Dec 18, 2017
rullzer
left a comment
Member
There was a problem hiding this comment.
Just fixed the test.
BUt other than that 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick and painless,
create()already callscreateDistributed(), effectively no change.