handle exceptions in SMB::stat

[icewind1991]

Properly handle non existing/non readable files

[codecov]

Codecov Report

Merging #7556 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #7556 +/- ##
============================================
- Coverage 51.18% 51.18% -0.01% - Complexity 24874 24876 +2 
============================================
Files 1601 1601 Lines 94707 94712 +5 Branches 1368 1368 ============================================
Hits 48475 48475 - Misses 46232 46237 +5

Impacted Files	Coverage Δ	Complexity Δ
apps/files_external/lib/Lib/Storage/SMB.php	5.53% <0%> (-0.11%)	118 <5> (+2)

[rullzer]

Sounds sane

[rik26]

With Nextcloud 16, the problem still appears with symlink on share, i tested the following code, and it works :
I put a comment here too :
#7332

/**
* get the best guess for the modification time of the share
*
* @return int
*/
private function shareMTime() {
$highestMTime = 0;
$files = $this->share->dir($this->root);
foreach ($files as $fileInfo) {
try {
if ($fileInfo->getMTime() > $highestMTime) {
$highestMTime = $fileInfo->getMTime();
}
} catch (NotFoundException $e) {
// Ignore this, can happen on unavailable DFS shares
- }
+ } catch (ForbiddenException $e) {
+ // Ignore this too : symlink
+ }
}
return $highestMTime;
}

[icewind1991]

@rik26 can you submit a PR with your change

[rik26]

@icewind1991 It's not i'm not willing to help, but i don't understand how to make a PR... And sorry for the duplicate but as the issue was closed i created a new one ...

#15876

Sorry for being useless..

[MorrisJobke]

Sorry for being useless..

You are not useless. Thanks for the hint already.

I opened a PR at #16195