Uh oh!
There was an error while loading. Please reload this page.
[stable12] Fix email buttons for white theme - #7558
Merged
Merged
Conversation
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
commented
Dec 18, 2017
MemberAuthor
I just tested this and it works fine 👍 |
blizzz
reviewed
Dec 18, 2017
| /** | ||
| * Returns primary color | ||
| * @return string | ||
| * @since 13.0.0 |
MemberAuthor
There was a problem hiding this comment.
Yes - but I just don't want to change it all the way - for this single time it is a bit off, but shouldn't hurt or does it? Because adding "since 12.0.5" doesn't add that much.
Member
There was a problem hiding this comment.
Agreed. No app should really depend on it anyways as it isn't available in 12 in general.
Codecov Report
@@ Coverage Diff @@## stable12 #7558 +/- ##
==============================================
- Coverage 53.93% 53.93% -0.01% - Complexity 22705 22708 +3
==============================================
Files 1385 1385 Lines 86978 86986 +8 Branches 1330 1330 ==============================================
+ Hits 46914 46916 +2 - Misses 40064 40070 +6
|
rullzer
approved these changes
Dec 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #7427
Fixes#7557 for stable12