Skip to content

Use injected AppManager - #7560

Merged
rullzer merged 1 commit into
masterfrom
fix_7309
Dec 18, 2017
Merged

Use injected AppManager#7560
rullzer merged 1 commit into
masterfrom
fix_7309

Conversation

@rullzer

@rullzerrullzer commented Dec 18, 2017

Copy link
Copy Markdown
Member

Fixes#7309

Easy PR of the day:

Run: ./occ maintenance:repair

Before: 💥
Now: no 💥

@rullzer
Use injected AppManager
d6e74fe
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added 3. to review Waiting for reviews bug labels Dec 18, 2017
@rullzerrullzer added this to the Nextcloud 13 milestone Dec 18, 2017
@rullzerrullzer mentioned this pull request Dec 18, 2017
Closed
@enoch85

enoch85 commented Dec 18, 2017

Copy link
Copy Markdown
Member

Fixes the issue for me! 👍

@enoch85
enoch85 self-requested a review December 18, 2017 19:47
ChristophWurst
ChristophWurst approved these changes Dec 18, 2017
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 18, 2017
@codecov

codecovBot commented Dec 18, 2017•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7560 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #7560 +/- ##
============================================
+ Coverage 51.17% 51.18% +<.01% 
Complexity 24874 24874 ============================================
Files 1601 1601 Lines 94707 94707 Branches 1368 1368 ============================================
+ Hits 48469 48475 +6 + Misses 46238 46232 -6
Impacted FilesCoverage ΔComplexity Δ
core/Command/Maintenance/Repair.php0% <0%> (ø)19 <0> (ø)⬇️
core/js/js.js63.55% <0%> (+0.56%)0% <0%> (ø)⬇️
lib/private/Files/Cache/Propagator.php96.2% <0%> (+1.26%)16% <0%> (ø)⬇️

@rullzer
rullzer merged commit 60297ed into masterDec 18, 2017
@rullzer
rullzer deleted the fix_7309 branch December 18, 2017 20:26
@MorrisJobkeMorrisJobke mentioned this pull request Jan 2, 2018
Merged
30 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991icewind1991icewind1991 approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@enoch85enoch85enoch85 approved these changes
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke
@blizzzblizzzAwaiting requested review from blizzz
@danxuliudanxuliuAwaiting requested review from danxuliu

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 13

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer@enoch85@icewind1991@ChristophWurst