Skip to content

Let DI handle the background job - #7561

Merged
rullzer merged 1 commit into
masterfrom
fix_7548
Dec 18, 2017
Merged

Let DI handle the background job#7561
rullzer merged 1 commit into
masterfrom
fix_7548

Conversation

@rullzer

@rullzerrullzer commented Dec 18, 2017

Copy link
Copy Markdown
Member

Fixes#7548

The DI can now do the magic itself. It could not before so we tricked it in Server.php. However then we failed to update the call to the constructor.

Long story short. Let the DI do the magic.

@rullzer
Let DI handle the background job
0b71369
Fixes#7548
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added 3. to review Waiting for reviews bug labels Dec 18, 2017
@rullzerrullzer added this to the Nextcloud 13 milestone Dec 18, 2017
ChristophWurst
ChristophWurst approved these changes Dec 18, 2017
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DI all the things ✨ 🦄 🚀

@blizzzblizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 18, 2017
@codecov

codecovBot commented Dec 18, 2017•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7561 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #7561 +/- ##
============================================
+ Coverage 51.17% 51.18% +<.01% 
Complexity 24874 24874 ============================================
Files 1601 1601 Lines 94707 94701 -6 Branches 1368 1368 ============================================
+ Hits 48469 48474 +5 + Misses 46238 46227 -11
Impacted FilesCoverage ΔComplexity Δ
lib/private/Server.php81.34% <ø> (+0.32%)134 <0> (ø)⬇️
apps/files_trashbin/lib/Trashbin.php72.53% <0%> (+0.24%)136% <0%> (ø)⬇️
core/js/js.js63.55% <0%> (+0.56%)0% <0%> (ø)⬇️
lib/private/Security/CertificateManager.php92.07% <0%> (+0.99%)39% <0%> (ø)⬇️

@rullzer
rullzer merged commit 4ed12ff into masterDec 18, 2017
@rullzer
rullzer deleted the fix_7548 branch December 18, 2017 20:12
@MorrisJobke

MorrisJobke commented Dec 18, 2017

Copy link
Copy Markdown
Member

We should do this more often and the DI bootstrap container should be basically empty ;)

@MorrisJobkeMorrisJobke mentioned this pull request Jan 2, 2018
Merged
30 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@blizzzblizzzblizzz approved these changes
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke
@danxuliudanxuliuAwaiting requested review from danxuliu

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 13

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer@MorrisJobke@ChristophWurst@blizzz