Uh oh!
There was an error while loading. Please reload this page.
Fix opening the menu in a share page - #7566
Merged
Merged
Conversation
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
".popovermenu" elements are visible or not depending on whether they also have the "open" CSS class or not. "#header .menu" elements were always hidden, so when both rules applied to the same element, like in the menu of a Share page, the element was always hidden due to "#header .menu" being more specific than ".popovermenu" and thus overriding its rules. Now, "#header .menu" elements are hidden only if they are not a ".popovermenu" too. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Codecov Report
@@ Coverage Diff @@## master #7566 +/- ##
=========================================
Coverage 51.16% 51.16% Complexity 24883 24883 =========================================
Files 1602 1602 Lines 94731 94731 Branches 1368 1368 =========================================
Hits 48472 48472 Misses 46259 46259
|
MorrisJobke
commented
Dec 19, 2017
Member
rullzer
approved these changes
Dec 19, 2017
jancborchardt
commented
Dec 19, 2017
Member
Thanks a lot @danxuliu! |
skjnldsv
commented
Dec 19, 2017
Member
Thanks @danxuliu 💘 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a regression introduced in commit 2348d14. Since that commit the menu of a Shared file page (in the Files app, open the right sidebar and the Sharing tab for a file, enable Share link and open that link) is no longer opened when clicking on the top right area of the header.
.popovermenuelements are visible or not depending on whether they also have theopenCSS class or not.#header .menuelements were always hidden, so when both rules applied to the same element, like in the menu of a Share page, the element was always hidden due to#header .menubeing more specific than.popovermenuand thus overriding its rules. Now,#header .menuelements are hidden only if they are not a.popovermenutoo.