Skip to content

Respect sharing options when searching for Sharees - #7567

Merged
MorrisJobke merged 1 commit into
stable12from
stable-12_fix7428
Dec 20, 2017
Merged

Respect sharing options when searching for Sharees#7567
MorrisJobke merged 1 commit into
stable12from
stable-12_fix7428

Conversation

@LEDfan

Copy link
Copy Markdown
Member

Backport of #7490

I didn't backported the tests because some results are returned in the method and some are set using sharees->result.

… we may not share with
Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
@LEDfanLEDfan added the 3. to review Waiting for reviews label Dec 19, 2017
@codecov

codecovBot commented Dec 19, 2017

Copy link
Copy Markdown

Codecov Report

Merging #7567 into stable12 will decrease coverage by <.01%.
The diff coverage is 11.11%.

@@ Coverage Diff @@## stable12 #7567 +/- ##
==============================================
- Coverage 53.93% 53.93% -0.01% - Complexity 22708 22712 +4 
==============================================
Files 1385 1385 Lines 86986 86995 +9 Branches 1330 1330 ==============================================
+ Hits 46916 46918 +2 - Misses 40070 40077 +7
Impacted FilesCoverage ΔComplexity Δ
...es_sharing/lib/Controller/ShareesAPIController.php63.23% <11.11%> (-1.24%)118 <0> (+4)
apps/files_trashbin/lib/Trashbin.php72.28% <0%> (-0.25%)136% <0%> (ø)
lib/private/Server.php84.8% <0%> (+0.12%)121% <0%> (ø)⬇️
apps/files_trashbin/lib/Expiration.php91.93% <0%> (+1.61%)29% <0%> (ø)⬇️

@rullzerrullzer added this to the Nextcloud 12.0.5 milestone Dec 19, 2017

@blizzzblizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
MorrisJobke merged commit 9ed0f50 into stable12Dec 20, 2017
@MorrisJobke
MorrisJobke deleted the stable-12_fix7428 branch December 20, 2017 13:18
@MorrisJobkeMorrisJobke mentioned this pull request Jan 8, 2018
13 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@LEDfan@MorrisJobke@blizzz@rullzer