Uh oh!
There was an error while loading. Please reload this page.
Conversation
Fixes#7574 During some refactoring the event linked to password reset got removed. This ment that we just submitted a normal POST but without the CSRF token. And none of the js magic to redirect afterwards. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Codecov Report
@@ Coverage Diff @@## master #7576 +/- ##
=========================================
Coverage 51.16% 51.16% Complexity 24883 24883 =========================================
Files 1602 1602 Lines 94730 94730 Branches 1368 1368 =========================================
Hits 48470 48470 Misses 46260 46260
|
skjnldsv
approved these changes
Dec 19, 2017
skjnldsv
left a comment
Member
There was a problem hiding this comment.
Code looks good and makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#7574
During some refactoring the event linked to password reset got removed.
This ment that we just submitted a normal POST but without the CSRF
token. And none of the js magic to redirect afterwards.
To test:
Before:
💥
Now:
Proper redirect to the login page again.