Skip to content

Spelling: No ...., upgrades and email. - #7583

Merged
MorrisJobke merged 2 commits into
masterfrom
comradekingu-patch-1
Jan 2, 2018
Merged

Spelling: No ...., upgrades and email.#7583
MorrisJobke merged 2 commits into
masterfrom
comradekingu-patch-1

Conversation

@comradekingu

Copy link
Copy Markdown
Contributor

No description provided.

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, beside my inline comment

Comment threadsettings/js/apps.js Outdated
if (!_.isUndefined(app.author['@attributes']['mail'])) {
authors.push(app.author['@attributes']['mail']);
if (!_.isUndefined(app.author['@attributes']['email'])) {
authors.push(app.author['@attributes']['email']);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Dec 20, 2017
@MorrisJobkeMorrisJobke added this to the Nextcloud 13 milestone Dec 20, 2017
@rullzer
rullzerforce-pushed the comradekingu-patch-1 branch from 6ae6c39 to e908722CompareDecember 29, 2017 20:16
@codecov

codecovBot commented Dec 29, 2017

Copy link
Copy Markdown

Codecov Report

Merging #7583 into master will decrease coverage by 1.13%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #7583 +/- ##
============================================
- Coverage 29.15% 28.02% -1.14% 
Complexity 23574 23574 ============================================
Files 1445 1445 Lines 78871 82252 +3381 ============================================
+ Hits 22996 23051 +55 - Misses 55875 59201 +3326
Impacted FilesCoverage ΔComplexity Δ
lib/private/App/CodeChecker/DeprecationCheck.php10.1% <0%> (-89.9%)5% <0%> (ø)
...b/private/App/AppStore/Bundles/EducationBundle.php28.57% <0%> (-71.43%)2% <0%> (ø)
lib/private/App/CodeChecker/PrivateCheck.php29.41% <0%> (-70.59%)5% <0%> (ø)
lib/private/OCS/Provider.php32.81% <0%> (-67.19%)7% <0%> (ø)
.../tests/Unit/Collaboration/CommentersSorterTest.php25.55% <0%> (-66.45%)6% <0%> (ø)
.../private/App/AppStore/Bundles/EnterpriseBundle.php36.36% <0%> (-63.64%)2% <0%> (ø)
...ivate/App/AppStore/Bundles/SocialSharingBundle.php40% <0%> (-60%)2% <0%> (ø)
apps/dav/lib/Capabilities.php40% <0%> (-60%)1% <0%> (ø)
...b/private/App/AppStore/Bundles/GroupwareBundle.php50% <0%> (-50%)2% <0%> (ø)
apps/sharebymail/tests/SettingsTest.php52.17% <0%> (-47.83%)3% <0%> (ø)
... and 368 more

comradekinguand others added 2 commits January 2, 2018 09:47
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
rullzerforce-pushed the comradekingu-patch-1 branch from e908722 to f801dc8CompareJanuary 2, 2018 08:48
@MorrisJobke
MorrisJobke merged commit 99175c3 into masterJan 2, 2018
@MorrisJobke
MorrisJobke deleted the comradekingu-patch-1 branch January 2, 2018 10:44
@MorrisJobkeMorrisJobke mentioned this pull request Jan 2, 2018
30 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@comradekingu@rullzer@MorrisJobke