Skip to content

Hide stay logged in checkbox when flow authentication is used - #7590

Merged
MorrisJobke merged 1 commit into
masterfrom
flow-hide-stay-logged-in
Jan 2, 2018
Merged

Hide stay logged in checkbox when flow authentication is used#7590
MorrisJobke merged 1 commit into
masterfrom
flow-hide-stay-logged-in

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

Fix for #7234

@juliusknorrjuliusknorr added 3. to review Waiting for reviews enhancement papercut Annoying recurring UX issue with possibly simple fix. labels Dec 20, 2017
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@rullzer
rullzerforce-pushed the flow-hide-stay-logged-in branch from 5ef5743 to f5f6ed6CompareDecember 28, 2017 10:15
@codecov

codecovBot commented Dec 28, 2017

Copy link
Copy Markdown

Codecov Report

Merging #7590 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #7590 +/- ##
============================================
- Coverage 51.17% 51.16% -0.01% - Complexity 24886 24887 +1 
============================================
Files 1602 1602 Lines 94752 94753 +1 Branches 1368 1368 ============================================
- Hits 48485 48482 -3 - Misses 46267 46271 +4
Impacted FilesCoverage ΔComplexity Δ
core/templates/login.php0% <ø> (ø)0 <0> (ø)⬇️
core/Controller/LoginController.php78.72% <100%> (+0.86%)39 <0> (+1)⬆️
lib/private/Security/CertificateManager.php91.08% <0%> (-1%)39% <0%> (ø)
core/js/js.js62.98% <0%> (-0.57%)0% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php72.28% <0%> (-0.25%)136% <0%> (ø)
lib/private/Server.php81.55% <0%> (+0.11%)134% <0%> (ø)⬇️
apps/files_trashbin/lib/Expiration.php91.93% <0%> (+1.61%)29% <0%> (ø)⬇️

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobkeMorrisJobke added this to the Nextcloud 13 milestone Jan 2, 2018
@MorrisJobke
MorrisJobke merged commit 37ed5b5 into masterJan 2, 2018
@MorrisJobke
MorrisJobke deleted the flow-hide-stay-logged-in branch January 2, 2018 10:27
This was referenced Jan 2, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsenhancementpapercutAnnoying recurring UX issue with possibly simple fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr@rullzer@MorrisJobke