Uh oh!
There was an error while loading. Please reload this page.
Update quota on files upload - #7592
Merged
Merged
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
requested review from
LukasReschke, MorrisJobke, jancborchardt and rullzerDecember 21, 2017 09:50
skjnldsv
commented
Dec 21, 2017
| </li> | ||
| <?php } ?> | ||
| <li id="quota" class="pinned <?php | ||
| <li id="quota" class="pinned <?php p($pinned===0?'first-pinned ':'') ?><?php |
MemberAuthor
There was a problem hiding this comment.
This fixes the pinned position of the quota if the files_trashbin app is disabled (meaning no other apps have registered another app-navigation pinned entry)
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Codecov Report
@@ Coverage Diff @@## master #7592 +/- ##
============================================
- Coverage 51.17% 50.67% -0.51%
Complexity 24886 24886 ============================================
Files 1602 1538 -64 Lines 94750 87002 -7748 Branches 1368 0 -1368 ============================================
- Hits 48485 44085 -4400 + Misses 46265 42917 -3348 |
skjnldsv
commented
Dec 26, 2017
MemberAuthor
Build failure unrelated. |
rullzer
approved these changes
Dec 28, 2017
skjnldsv
commented
Dec 30, 2017
MemberAuthor
Apparently there is a race condition sometimes where the quota status get requested before the MOVE request gets executed. Which result in an incomplete update. I'll fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#6690
