Uh oh!
There was an error while loading. Please reload this page.
Fixes for TimestampFormatter - #7608
Merged
Merged
Conversation
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
pimp_timestampformatter
branch
from
December 22, 2017 12:43
624460f to
735b9fbCompareCodecov Report
@@ Coverage Diff @@## master #7608 +/- ##
=========================================
Coverage 51.17% 51.17% Complexity 24886 24886 =========================================
Files 1602 1602 Lines 94750 94750 Branches 1368 1368 =========================================
Hits 48485 48485 Misses 46265 46265
|
blizzz
approved these changes
Dec 22, 2017
ChristophWurst
approved these changes
Dec 27, 2017
| */ | ||
| public function hasStyle($name) { | ||
| $this->formatter->hasStyle($name); | ||
| return $this->formatter->hasStyle($name); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at the code (to use in the previewgenerator). And noticed some things that needed fixing.
Easy PR of the day.