Uh oh!
There was an error while loading. Please reload this page.
Support IPv6 for database servers - #7621
Closed
Marlinc wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Marlin Cremers <m.cremers@cvo-technologies.com>
Codecov Report
@@ Coverage Diff @@## master #7621 +/- ##
============================================
+ Coverage 51.17% 51.17% +<.01% - Complexity 24886 24887 +1
============================================
Files 1602 1602 Lines 94750 94750 Branches 1368 1368 ============================================
+ Hits 48485 48486 +1 + Misses 46265 46264 -1
|
| } else { | ||
| $host = $this->config->getValue('dbhost', ''); | ||
| if (strpos($host, ':')) { | ||
| if (strpos($host, ':') && !strstr($host, '[')) { |
Member
There was a problem hiding this comment.
Can you change this to if (strpos($host, ':') !== false && strpos($host, '[') === false) {
Member
There was a problem hiding this comment.
@Marlinc Could you do this change? Otherwise we would close this and adjust it ourselves.
nickvergessen
commented
Apr 18, 2018
Member
Replaced with #9225 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for IPv6 addresses in the hostname field of a database connection.